department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

VAMC Medical Records: adopt V1 and V3 components where components are not used #16960

Closed laflannery closed 5 months ago

laflannery commented 8 months ago

Description

VAMC Medical Records pages need the following updates to components:

Example pages:

Elements that are not using components that should be

  1. ~Telephone~
    • ~Location Phone numbers are using the component but we want to make sure exts are being parsed correctly~
  2. ~Link~
    • ~Facility names should use the link component~
  3. Back to top component
    • Update 5/3: After determining that this component does not actually have built in intelligence to only show based on page height:
      • This should still be added, the Top task pages are on the longer side so having this on these pages will probably make sense more often than not.

Not in scope: V1 components that need to be upgraded - DONE

  1. ~Alert~
    • ~Currently using the v1 component but needs to be updated to v3~
  2. ~Accordion~
    • ~Medical records accordion section is using v1 component and needs to be updated to v3.~
  3. ~Button~
    • ~It is inside the alert and is currently using the v1 component but needs to be updated to v3.~

Acceptance Criteria

maxx1128 commented 7 months ago

I estimate this ticket at a 5 for moving over a good amount of relatively simple elements over to components but also upgrading a few extra ones. It's another "If I could make it a 4, I would" scenario, so I'm rounding up.

laflannery commented 6 months ago

Alert and button are already v3: Screenshot 2024-03-27 at 10 53 58 AM

My thought is that it happened with this PW ticket for the CTA widget

laflannery commented 6 months ago

Accordions have also already been updated to V3: Screenshot 2024-03-27 at 10 59 25 AM

I believe I tracked this update down to this PW ticket

laflannery commented 6 months ago

Last update: I removed the link component from this ticket, after working with PW, the links I noted are CMS content and we are limited with what we can do with that type of content

laflannery commented 6 months ago

Telephone moved to #16148

eselkin commented 5 months ago

Links in text are in the form of wysiwyg paragraphs so drupal content. The non-clinical service location paragraphs are handled by #16957. It's likely only the back-to-top will be left, but will say 2 just in case.

laflannery commented 5 months ago

Confirmed on prod, closing