department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Update VAMC Facility template to adopt V3 accordion component #16963

Closed laflannery closed 7 months ago

laflannery commented 9 months ago

Description

VAMC Facility pages need the following updates to components:

Example pages:

List of Components

V1 components that need to be upgraded (Actionable)

  1. Accordion
    • Accordion sections (Prepare for your visit and services) are using the v1 component and need to be updated to v3.

Not in scope

Acceptance Criteria

maxx1128 commented 8 months ago

I estimate this ticket at a 3 for moving over a good amount of relatively simple elements over to components.

jilladams commented 7 months ago

TO DO: @jilladams split out V1 work to new ticket

eselkin commented 7 months ago

Should this also change: https://va.gov/boston-health-care/health-services/?

Nevermind, I see there's another ticket for that.

jilladams commented 7 months ago

Due to #17807 popping up, where adoption of components ran into some browser-specific styling issues, I've added ACs here to cover cross-browser verification.

laflannery commented 7 months ago

Screenshots from Eli's PR for ACs:

FF Windows image

Edge (I didn't put the fancy bookmarklet on Edge but confirmed these are the v3 variant) image

Chrome Windows image

FF Mac Screenshot 2024-04-11 at 8 21 29 AM

Chrome Mac Screenshot 2024-04-11 at 8 12 17 AM

Safari (no bookmarklet) Screenshot 2024-04-11 at 8 14 19 AM

Mobile image

jilladams commented 7 months ago

Thoughts: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/16997#issuecomment-2050641295 tl;dr: let's use mobile emulator to test lower envs on desktop, and verify on phones in prod.

laflannery commented 7 months ago

Update above comment to include mobile emulator screenshot

laflannery commented 7 months ago

Confirmed on Prod: Screenshot 2024-04-15 at 8 39 10 AM