department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

[V1 & 3 Components] Implement available components for Resources & Support landing page #16986

Closed FranECross closed 8 months ago

FranECross commented 9 months ago

Background

The Design team is releasing a Typography update (sometime in March), which means that the PW team needs to upgrade any of our products where components aren't currently being using, but a V1 or V3 component is available.

If the updates aren't made prior to the Typography update, there's a chance that Veteran-facing issues may occur.

The following have been identified by Laura Flannery:

Resources Landing Page

Elements that are not using components that should be

  1. ~Breadcrumbs~ Covered by #17162 ~- Not using any component but should be using v3~
  2. Link
  3. Search input
  4. Radio buttons
    • There might be some technical limitations here, I'm not sure but if possible we should be using v3 components
  5. Button

Documentation

Sitewide V3 DS component review spreadsheet

User story

AS A PO/PM for Public Websites products I WANT to implement available V1 or V3 components in features & products currently under Public Websites management where components aren't currently being used SO THAT all PW products are in alignment with the current component version AND Veterans and other users have a consistent experience throughout VA.gov tools and information

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

randimays commented 8 months ago

@FranECross @jilladams Can I remove breadcrumbs from the scope of this ticket, given that we have https://github.com/department-of-veterans-affairs/va.gov-cms/issues/17162?

jilladams commented 8 months ago

Yep - we confirmed that yesterday live. Making the change here.

randimays commented 8 months ago

I am working on this one plus #17199. Struggling with pagination (from #17199) as the v3 component has elements in the shadow DOM, and we have to add a click handler to change the pages and can't access the shadow DOM elements. I have been communicating with Jami from the DST about it here: https://dsva.slack.com/archives/C01DBGX4P45/p1708967336736359 hopefully we can find a solution!

All other components have been completed, but we still need an accessibility review of everything once it's complete.

randimays commented 8 months ago

Update: The PR (https://github.com/department-of-veterans-affairs/vets-website/pull/28236) is ready for review. It excludes any web component updates for <button>. There is a single <button> used for the expand/collapse behavior on mobile:

Screenshot 2024-03-01 at 10 24 56 AM

This does not need to be converted to a web component as it is stylistically very different from the web component. I have request an accessibility review that we can hopefully get on Monday when Laura returns from PTO.

randimays commented 8 months ago

Accessibility review is completed and the changes are verified in production. Closing!