department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Audit design elements in PW-owned features #17173

Open FranECross opened 9 months ago

FranECross commented 9 months ago

Status

[2024-04-25] Per Laura F, she'll do her accessibility audit, and will create tickets for any accessibility issues, general improvements she thinks should be made. Then we'll turn this over to Jordan for her review.

Description

Conduct an audit on all design elements (buttons, etc.) in PW-owned features to ensure we're using the most current element the Design team has created (unless there is a compelling reason we detracted from the design).

User story

AS A PO/PM for PW-owned features I WANT our features to use the most current design elements, unless there was/is a compelling reason we detracted from them SO THAT Veterans, their family members, caregivers, and/or survivors have a consistent experience in VA.gov, thus increasing their trust in the features and information we provide for them.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

FranECross commented 9 months ago

@thejordanwood Here's the Spike Dave mentioned during backlog refinement today; I've moved it into Next Refinement to chat about during our next UX prefinement meeting. As discussed, no rush. I've also created an epic and linked. cc @davidconlon

thejordanwood commented 9 months ago

Relevant comment Laura made about material honesty with buttons v links in another ticket.

However this does break material honesty (meaning these visually look like a button but programmatically it's a link). This is something I would ticket separately and ask @thejordanwood to see if she can provide a better suggestion for what we should be doing here. Maybe it's just a standard link, or maybe it's something else

FranECross commented 7 months ago

@thejordanwood @laflannery @jilladams @randimays Is his ticket still needed, or was an audit/review done when prior to and during the V1 to V3 work?

jilladams commented 7 months ago

We did the components audit. I don't know that we've covered all of the other sorts of design question we could -- will defer to Jordan / Laura on that.

thejordanwood commented 7 months ago

@FranECross @jilladams I don't feel like we've covered all the design questions we could. I'd like to leave this ticket open to give me time to review our products. Maybe nothing will come out of it, but something might.

laflannery commented 7 months ago

@thejordanwood This could be handled with what Amanda and I discussed as next steps from all my accessibility audits. The loose plan right now is that once I'm done with my audits we want to have a full design review of all those same products