Run menu re-org script on prod and fix Lovell

swirtSJW commented 9 months ago

User Story or Problem Statement

Relates to https://github.com/department-of-veterans-affairs/va.gov-cms/issues/16233

We need to execute the script introduced by this PR once it lands on prod.

Notes

It does NOT have to be urgent and go right after the code deployment. It can wait until whenever we choose.
The script takes roughly an hour to run, but there is no risk window, There is nothing that can happen during that hour that we need to undo or re-do.

Steps for Implementation

Devops

Once the code from https://github.com/department-of-veterans-affairs/va.gov-cms/pull/17189 lands on prod:

[ ] SSH to prod
[ ] become the drush user
[ ] Set the state to the last menu that was processed correctly ddev drush state:set script_library__va_gov_vamc_get_system_menus 117
[ ] re-run drush scr ./scripts/content/VACMS-16233-reorder-vamc-menu-items.php
- will count off like this
- It should take somewhere just 15 min to run.
- If for some reason it fails, it is safe to run as many times as needed to finish. It will pick up where it left off.
[ ] Notify Facilities team that it is done.

Facilities team

Once the devops process ^^ is complete:

[x] Login as admin
[x] Go to the Lovell menu
Lovell has duplicate menu items due to its dual nature.
One of each of the pairs will be in the right order, the others will not be. (and some may not have pairs)
[x] Move the errant menu items so they are adjacent to their twin and in the order matching
```
About us
Programs
Research
Policies
VA police
Work with us
Contact us
```
[x] Save the menu.

Team

Please check the team(s) that will do this work.

[x] CMS Team
[ ] Public Websites
[x] Facilities
[ ] Accelerated Publishing

swirtSJW commented 9 months ago

I just updated the steps to have this pick up where it left off, once https://github.com/department-of-veterans-affairs/va.gov-cms/pull/17236 lands on prod.

omahane commented 9 months ago

I've moved Lovell.

michelle-dooley commented 9 months ago

@7hunderbird can assist as needed.

7hunderbird commented 9 months ago

I will be working with @edmund-dunn on this issue because I'm still on-boarding access.

jilladams commented 8 months ago

@xiongjaneg @omahane this ticket shows as a Facilities team ticket in our Icebox, but also in Sprint 104. Could one of you confirm if this is in current sprint?

xiongjaneg commented 8 months ago

@jilladams This was a script we needed help from CMS Team to run so I've updated the labels.

gracekretschmer-metrostar commented 8 months ago

@edmund-dunn

jilladams commented 8 months ago

@edmund-dunn @gracekretschmer-metrostar could you clarify if there is work remaining on this ticket in upcoming sprint, or if it's been run in prod and we can verify our changes?

gracekretschmer-metrostar commented 8 months ago

@jilladams Due to the focus on resolving the BRD breakdown, we have not been able to complete this task, but I will get this task to be prioritized to be completed by end of next week (3/8). Thank you for your patience!

omahane commented 8 months ago

@gracekretschmer-metrostar I asked @edmund-dunn about this yesterday, and he said it ran successfully.

it's confusing, because we have 2 tickets that describe the same thing:

a pull request: https://github.com/department-of-veterans-affairs/va.gov-cms/pull/17236
an issue: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/17202

The pull request describes the testing steps, but the same could have been used with slight modifications by an engineer to run it on prod, which the issue ticket describes explicitly.

gracekretschmer-metrostar commented 8 months ago

Great! Disregard my comment then @omahane. I don't know why there are two tickets.

xiongjaneg commented 8 months ago

Noted earlier comment that a separate PR for DevOps ran successfully. This ticket for Drupal work is complete. Verified menu order of Lovell on prod.

department-of-veterans-affairs / va.gov-cms