department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

[EPIC] Standardize phone numbers on Support Services #17326

Open laflannery opened 9 months ago

laflannery commented 9 months ago

Status

[2024-08-20] [Dave] Created separate tickets for Vanity and International phone numbers [2024-07-12] [Fran] 'Call us links' have NOT been updated to va-telephone components and we cannot stop using custom analytics on them currently. We need to update CMS phone number entry to standardize, then update FE to use DS component, in order to enable that analytics update.

Description

The Support Service content type is an older content type. The way phone numbers are created in Drupal on this content type, and the way those phone numbers are presented in the VA.gov front-end does not match current standards or use current widgets / design system components. The va-telephone DS component and the applicable props now do a lot of the display and functionality that the Support Service CMS fields are manually doing.

We would like to update this content type to use modern standards.

Where Support services appear

CMS BE usage:

Screenshot ![Image](https://github.com/user-attachments/assets/d488a025-50d6-41b1-bf44-f9744a0a7975)

VA.gov FE:

The Related Office field on a Support Service is used to tie it to other content types / templates:

  1. On Benefit Hub Landing Pages: right sidebar, "Ask questions" panel. The Offices field is used to create the relationship between the Hub and the Support Service. e.g. Education & training
  2. Resources & Support detail page: Need more help panel at the bottom of the page, e.g. Login.gov R&S page
Screenshots ![Image](https://github.com/user-attachments/assets/55a3709e-c727-4bc6-92fa-981c693aca41) ![Image](https://github.com/user-attachments/assets/14b733e6-4268-458c-ad34-b8d31c937a37)

Considerations for updates:

Drupal

FE

Vanity numbers

The GIBILL number is an exception: Link = tel: 1-888-442-4551; Phone Number = [888-GIBILL-1 (888-442-4551)](tel:888-GIBILL-1%28888-442-4551%29). This number is not handled by the va-telephone component. Has been ticketed to the DST: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/2531.

This epic is essentially blocked until the parent epic around Vanity number support has been addressed both in Drupal and by the DST.

omahane commented 7 months ago

The only place that we have something like what you're describing for the phone number at present is in Service Locations, using the field_phone (a paragraph type). https://prod.cms.va.gov/node/add/health_care_local_health_service Screenshot 2024-04-10 at 17 38 29

randimays commented 5 months ago

FE QUESTION: Should they not be entering the dashes between the numbers either? Should be be validating and/or providing help text against that or is that ok and the component can handle those?

The web component doesn't like dashes. In many cases we're having to remove them in content-build / the FE

Could we make changes now, update the CMS and the front end but allow this GIBILL number to not use the component?

We can make exceptions in the code for this type of phone number 👍🏻

FranECross commented 4 months ago

@davidmpickett @dsasser @jv-agile6 I feel like this needs some review/love love outside of a refinement meeting to determine the best approach. Would all/some of you be the ones to do that? BTW this ticket is currently blocking implementing the 'va-telephone' component. Thanks! (I'm scooting it back to the backlog. cc @Agile6MSkinner

davidmpickett commented 4 months ago

This sounds like the exact same work as we will be doing in the Q3 Phone Number effort.

laflannery commented 4 months ago

This requires more work that the existing phone pattern does not support:

If this pattern was considered a good option, we could consider adding additional options so that this could cover all scenarios needed for the component:

  • Vanity - If selected this should trigger an conditional field for the vanity info
  • International
davidmpickett commented 4 months ago

Got it, so we'd likely need to update the Phone Paragraph type with those new options and then implement

davidmpickett commented 4 months ago

@laflannery I took a first pass at adding task lists here. Would love a sanity check.

One of the first steps would be defining the exact requirements for the Vanity and International phone number types. Do you feel like you have the info to specify those? Or should we make a little spike ticket for you and I to collaborate on that?

Agile6MSkinner commented 2 months ago

Going to put this in a future epic for vanity/international, etc.

jilladams commented 2 weeks ago

Took a look at this ticket today since DS is about to update the va-telephone component for int'l numbers.

FYI: There are a grand total of 17 published Support Services.

I am fishing around based on the Support services content model docs and am having a hard time finding where any of these are actually used in modern content.

Which is all to say: all this work on behalf of Support Services seems like very low priority, and we should check first with CAIA about when / why they choose to use SS before we try to prioritize this.

laflannery commented 2 weeks ago

@jilladams These numbers are used in a couple places (It's above in the Additional info section of the ticket description):

VA.gov FE usage: These phone numbers are used in the right column of benefits landing pages, example: Education & training as well as in the Need more help at the bottom of multiple resources pages

jilladams commented 2 weeks ago

AH! Thank you, Laura.

@FranECross FYI: Updated this ticket today to reflect the fact that it's actually an epic, and is a child of the greater #19121 International / Vanity effort. Put task lists that used to be in ticket body into tickets that are now children of the epic. It'll be PW work if/when the bigger picture Vanity / Intl work & DST blockers are gone.