[Find Forms] File needs adjusting re: components, va-alert, and correct missing <!DOCTYPE html>

FranECross commented 5 months ago

Status

[2024-07-02] @FranECross to look into this to get more details on the exact issue and then determine ownership of the fix, if any is needed. This is a change to dev only; not a prod issue. Low priority.

Description

Rob Garrison discovered that the file noted below has the following issues (but maybe some of them were taken care of in the recent component work?):

is should be using the component library, but isn't (his comment here > "The foundation CSS definitions will be removed sometime in the future. I made an attempt to update the template, but the web component wasn't working. Maybe it's showing up before web components are initialized, so whomever implements this may need to reach out to the Design System Team (#platform-design-system) for assistance"
There is also a usa-alert that needs to be converted into a va-alert web component in there
The template is missing a <!DOCTYPE html> at the top of the page

src/applications/find-forms @department-of-veterans-affairs/vfs-public-websites-frontend @department-of-veterans-affairs/va-platform-cop-frontend

User story

AS A PO/PM I WANT the find-forms file to be correctly using components SO THAT Veterans don't encounter visual or assistive tech issues when viewing the page

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

[ ] The web component is working correctly on the template/page
[ ] The usa-alert has been converted into a va-alert web component
[ ] The missing a <!DOCTYPE html> has been added to the top of the page

FranECross commented 5 months ago

@Mottie @jilladams Here's the ticket mentioned today in Slack. I'm cross posting the ticket link in the convo, too.

jilladams commented 5 months ago

Thanks Fran! When we refine this, first step I'm thinking is for Randi / Chris to sign off on how much if any of this got done under the other components ticket(s) for Find a Form updates.

FranECross commented 5 months ago

@jilladams Great point! I added a sentence to the description regarding checking to see if the recent component work took care of any of this.

FranECross commented 5 months ago

@FranECross to look into this to get more details on the exact issue and then determine ownership of the fix, if any is needed. This is a change to dev only; not a prod issue. Low priority.

department-of-veterans-affairs / va.gov-cms