search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
79 stars 59 forks source link

[V3 Components] Update Action Links to the new V3 component #17557

Open FranECross opened 3 months ago

FranECross commented 3 months ago

Status

[2024-07-03] Converting to an epic, and will create one ticket per product (as Randi suggests). If any have already been taken care of in other component tickets, we'll just close as a no op. [2024-06-10] Moved back to Blocked > Randi noted that DST has not yet released this component (though the work has been merged/closed). Once it is available (see releases here: https://github.com/department-of-veterans-affairs/component-library/releases) we can pull this ticket in. [2024-06-05] Ticket 2500 has been completed and close. Unblocking this ticket and moving it to Stretch/Next Sprint. [2024-05-30] This ticket is still blocked. The DST ticket is in progress Link - Action Web Component - Development #2500 [2024-05-23] Moved to Next refinement because the blocking ticket is in the DST current sprint. [2024-05-21] Still blocked by ticket noted below. [2024-05-15] Still blocked by ticket noted below. [2024-05-07] Still blocked by ticket noted below.

Description

The Design System Team will be building a component for the Action link, and this ticket is a gathering place for PW-management features/products where the Action link will need to be updated when the new component is available.

Blocked by: Link - Action Web Component - Development

User story

AS A PO/PM I WANT the Action Links to use the new V3 component when it's available SO THAT Veterans, their caregivers, family and survivors have a visually appealing experience in VA.gov, thus retaining their confidence in the site and the VA.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

FranECross commented 1 month ago

Will check to see when the DST ticket will be completed; this ticket may turn out to be parsed into many other tickets. @FranECross to check.

randimays commented 1 month ago

Noting that DST has not yet released this component (though the work has been merged/closed). Once it is available (see releases here: https://github.com/department-of-veterans-affairs/component-library/releases) we can pull this ticket in.

randimays commented 1 week ago

@FranECross This ticket is unblocked; DST released the action link component last Thursday: https://github.com/department-of-veterans-affairs/component-library/releases/tag/v42.2.0

This ticket isn't specific by product so I did a quick audit of where action links exist and should be converted. We already have #17276 and #17404 to cover the updates for Income Limits and PACT Act, so those aren't included in this list. We could have separate tickets for each of these products if you wish.

1. Discharge Upgrade Wizard ⚠️ Needs a ticket

2. Find Forms ✅ Done: 18346

3. BTSSS login ✅ In progress: 18419

4. Healthcare / CTA widgets ⚠️ Needs a ticket

5. Campaign Landing Pages ⚠️ Mostly done: 18419. Somehow I missed the video link 🤔

6. Events ✅ Ticket not started: 18457

7. Homepage ✅ Ticket not started: 18416

8. Resources & Support CTAs ⚠️ Needs a ticket Example: https://www.va.gov/resources/managing-your-vagov-profile/ "Find a medical center or regional office"

9. Facilities Health Services (local facility) ⚠️ Needs a ticket Example: https://www.va.gov/south-texas-health-care/locations/north-central-federal-va-clinic/ "Make an appointment," etc. links

10. Facilities Health Services (region) ⚠️ Needs a ticket Example: https://www.va.gov/south-texas-health-care/ "Make an appointment," etc. links

11. VBA Facilities "Make an appointment link ⚠️ Not sure if this needs a ticket Here's the custom analytics event on this component:

'vba-regional-facility-service-location-schedule-appointment',
'vba-regional-facility-name': '{{ facilityName }}',
'accordion-parent-label': '{{ entityName }}',
'link-label': 'Schedule an appointment online'

I'm not sure if we want to keep this custom event or convert this to a va-link-action component. The web component will have the text of the link, the destination URL and the origin URL only. @Agile6MSkinner @jilladams Do we need a ticket here?

12. Facilities Operating Status (region) ⚠️ Needs a ticket Example page: https://www.va.gov/texas-valley-health-care/operating-status/. This one does not have the "Subscribe to emergency notifications" action link that would be changed. I'm not sure where to find it; a prod example would be helpful for this ticket.

randimays commented 1 week ago

@laflannery I'm not sure if you've had the chance to do an accessibility review of the new action link web component. Here's what it looks like in the DOM.

I don't see any use cases for us with aria-labels, so the plain implementation should be what we need.

Screenshot 2024-06-24 at 9 57 01 AM
laflannery commented 1 week ago

@randimays This looks good, for the future, this does support aria-describedby but as you said I don't believe we need anything fancy at this time so the standard implementation should be all we need to use

randimays commented 1 week ago

@FranECross I just remembered some of the products' work above could be partly or completely covered by the analytics removal tickets.

FranECross commented 3 days ago

@randimays I'm happy to create tickets per product as you suggest, and can convert this ticket into an epic housing them. If any have already been taken care of, we can always just cross items off or close as a no op. Thanks for all the work you've done!

randimays commented 1 day ago

@FranECross @Agile6MSkinner I updated the comment above: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/17557#issuecomment-2186761178 We do need some tickets created to cover action link web components for Sitewide.