department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

[PR Review] Review PR for three CMS Team tickets #17558

Closed FranECross closed 6 months ago

FranECross commented 7 months ago

Description

The CMS team has PRs for three tickets (see below) which need review by the PW Team's Drupal expert. Targeting Sprint 107.

Tickets:

User story

AS THE CMS Team I WANT to have the PW Team's Drupal expert review the PRs for three of our tickets SO THAT we can receive suggested changes or approvals, thus increasing the confidence in the code not presenting issues to editors or Veterans, et al.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

FranECross commented 6 months ago

@dsasser will you please provide @gracekretschmer-metrostar an update on this ticket's progress? She's asked: Is there any way this could get completed in the next few days? I connected the dots that if PW does their review at the end of your current sprint and finds issues, that doesn't give the CMS team much time to fix those issues before 4/15 (when we are required to have the critical issues resolved).

Thanks in advance!

dsasser commented 6 months ago

@FranECross @gracekretschmer-metrostar

I have reviewed and approved the PR related to all of the affected tickets.

jilladams commented 6 months ago

PR merged, closing.