department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

[Events: a pipe (`|`) in Event title breaks event Share on Twitter link #17581

Open jilladams opened 5 months ago

jilladams commented 5 months ago

User Story or Problem Statement

Events with a | in the title break the "Share on Twitter" link that's built by the FE template.

Repro

Acceptance Criteria

jilladams commented 5 months ago

Worth noting: No idea how frequently anyone clicks the "Share on Twitter" link. Analytics on that might help determine priority here.

FranECross commented 5 months ago

Worth noting: No idea how frequently anyone clicks the "Share on Twitter" link. Analytics on that might help determine priority here.

@jilladams Analytics below for latter part of 2023. I think it gains enough clicks to prioritize for the next sprint. August 2023 = 324 September 2023 (spiked) = 1,958 October 2023 = 250

FranECross commented 5 months ago

@randimays @chriskim2311 Will you please async refine and estimate this ticket so that we can include it in the sprint that starts next week? Thanks in advance!

jilladams commented 5 months ago

Nice. Also occurred to me:

Events with | in title: https://prod.cms.va.gov/admin/content?title=%7C&type=event&moderation_state=All&owner=All

101 total, 4 created this year.

As to whether other special characters cause problems, tried a few: * @ etc. which work fine, so I suspect this might be specific to "control characters" < > { } | ` ^ \, and of those, pipe is the only one used in any Event titles.

Also, @FranECross it seems like the IIR team is trying to get rolling on Events. May be worth checking with Dave re: whether this goes to handoff or we fix it first

FranECross commented 5 months ago

@jilladams Thanks for all the spelunking and investigation! Also, great point about checking with Dave. I'll put on our Monday Product Sync agenda (unless you think this warrant's pinging him in Slack to get an answer sooner).