search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
78 stars 59 forks source link

component library update #17591

Open timcosgrove opened 2 months ago

timcosgrove commented 2 months ago

Requirements

The VA Design System needs updating, so that it is compatible with Next Build. ```[tasklist] ### Acceptance criteria - [ ] How can we verify the requirements have been met factually/quantifiably? ``` ## Background & implementation details

Typescript issues that need to be updated upstream; see Slack thread from the DST channel: https://dsva.slack.com/archives/C01DBGX4P45/p1710888039224269

tjheffner commented 2 months ago

v38.0.3 fixes most of the errors. The remaining error related to the Overlay component will require an upgrade to the stencil package that the component-library repo is using. This may or may not be prioritized soon, based on comments here:

https://dsva.slack.com/archives/C01DBGX4P45/p1711732915383109?thread_ts=1710888039.224269&cid=C01DBGX4P45

See this run for error details: https://github.com/department-of-veterans-affairs/next-build/actions/runs/8483541797/job/23244854099?pr=479

tjheffner commented 1 month ago

Updating from our current version of "@department-of-veterans-affairs/component-library": "^33.0.0", is blocked pending the DST upgrading their stencil version that generates the react bindings. The file containing the error is gitignored and generated via stencil.

See this slack thread for more details: https://dsva.slack.com/archives/C01DBGX4P45/p1712177213757299?thread_ts=1710888039.224269&cid=C01DBGX4P45

mreed101 commented 2 weeks ago

As of Mar 29th a ticket was created to do the stencil upgrade in the component library.

https://app.zenhub.com/workspaces/platform-design-system-5f8de67192551b0012ebb802/issues/gh/department-of-veterans-affairs/vets-design-system-documentation/2233

If the ticket has been completed, we will need to bump up our component-library package version to ^38.0.0, ideally 38.0.4

ttran-Therisa commented 18 hours ago

The Stencil upgrade seems to get pushed frequently to later sprints. It has now moved to be a part of sprint Aug 1-14 and removed from the sprint of Jun 20th - Jul 3rd

Updating from our current version of "@department-of-veterans-affairs/component-library": "^33.0.0", is blocked pending the DST upgrading their stencil version that generates the react bindings. The file containing the error is gitignored and generated via stencil.

See this slack thread for more details: https://dsva.slack.com/archives/C01DBGX4P45/p1712177213757299?thread_ts=1710888039.224269&cid=C01DBGX4P45