department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

FE Display of Non-Clinical Services on VAMC Top Task Pages should not be in a Card component #17632

Closed davidmpickett closed 5 months ago

davidmpickett commented 6 months ago

User Story or Problem Statement

In the tugboat Integration branch, non-clinical services on VAMC Top Task Pages are presenting inside a bordered box for Service Locations. This does not match the current design ( or future design, later).

Description or Additional Context

SCREENSHOTS Examples of 3 top task pages where the bordered box is visible, and needs to go away: ![screencapture-web-xptmfsnjoodldn85nzgkrgljqtfbz24b-ci-cms-va-gov-northeast-ohio-health-care-register-for-care-2024-03-25-22_08_15](https://github.com/department-of-veterans-affairs/va.gov-cms/assets/51967950/01b372f7-dea8-43b5-b86b-e2a603283bab) ![screencapture-web-xptmfsnjoodldn85nzgkrgljqtfbz24b-ci-cms-va-gov-northeast-ohio-health-care-billing-and-insurance-2024-03-25-22_08_07](https://github.com/department-of-veterans-affairs/va.gov-cms/assets/51967950/69acf3b9-7f5a-425a-8e71-a5f1b4f648e5) ![screencapture-web-xptmfsnjoodldn85nzgkrgljqtfbz24b-ci-cms-va-gov-northeast-ohio-health-care-medical-records-office-2024-03-25-22_07_56](https://github.com/department-of-veterans-affairs/va.gov-cms/assets/51967950/16b94a60-3bd7-4f5d-9443-3e0d25c6929a)

Steps for Implementation

Acceptance Criteria

jilladams commented 5 months ago

This is in PR. The Tugboat FE needs to be built from the PR branch in order to QA for merge. That is queued behind Christian's rebuild for the Unspecified = NULL migration fix.

thejordanwood commented 5 months ago

I reviewed the PR for this and have approved it.

Following up on spacing: @eselkin Thanks for bringing up in scrum that the space between the location header and the facility address is 48px instead of the 45px specified in the design mockup. In this case, I'm fine with the difference since the VADS ecosystem doesn't have the 45px spacing.

laflannery commented 5 months ago

I just want to note here for reference because it seems as though my direction on the PR looks to be in contrast to Jordan's comment above.

I am working off this Figma file in which the space between the Facility address and the "Location" header is 24px, which is just about the standard DS spacing (they actually state it should be 25.5px) Screenshot 2024-04-23 at 12 04 14 PM

This is why I have recommended in my comment we remove the extra large spacing and custom spacing I was seeing and stick instead with the standard DS spacing.

davidmpickett commented 5 months ago

This ticket was not supposed to include altering any spacing. it was only supposed to be about removing the border. I apologize for linking to a speculative WIP design as reference. By default, these should match the current spacing on Prod (which is 25.5)

Screenshot 2024-04-23 at 6 47 30 PM

davidmpickett commented 5 months ago

Last step is verifying this on SL tugboat after the migration finished and Content Release runs

davidmpickett commented 5 months ago

Confirmed on Tugboat Screenshot 2024-04-29 at 10 01 46 PM Screenshot 2024-04-29 at 10 02 00 PM