department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Update Spotlight form for VAMC Health System and Health Services #17688

Open jilladams opened 8 months ago

jilladams commented 8 months ago

Description

The Health services list and Vet Center content types in the CMS both have spotlight/featured content but they have different CMS fields and different displays on the front end than VBA and Vet Centers.

This is for Drupal alignment with Front end.

Design

Spotlight content page in VAMC facilities Figma file

User story

As an editor, I want a consistent pattern to create Spotlights across content types to reduce cognitive load and ensure good content hygiene.

From Figma review (#13804): my understanding of next steps for ticketing MVP is brain dumped below -- @thejordanwood could you sanity check, and if this is right, I'll work on ticketing (2 questions below):

Punch list of changes

VAMC Health Systems page:

update Common Links > Link teasers section:

Note: link field still has label URL instead of Link, intentionally.

VAMC Health services pages

Update "Featured content on health-services page" section to match VBA "Local spotlights" treatment.

Also: @mmiddaugh the designs include a stop-gap update for VAMCs, and a bigger overhaul to address specific use of phone / email as CTA. I can go ahead and build out those tickets, if we think this is something to go ahead and queue up / get refined for implementation? Not sure where that sits in priority, relative to All The Things. Will add to product sync Qs for Monday.

ACs

aklausmeier commented 8 months ago

I think the URL/Link fields are using different Drupal modules? I really can't remember the exact reasoning they're different, but have a vague memory of being told this in the past. I decided to keep this as URL since that's what it already says.

@thejordanwood Can we confirm, maybe engineers can assist in confirming?

thejordanwood commented 8 months ago

@davidmpickett @omahane My spotlight designs in the Figma file have a Link field for the spotlight sections on VBA/Vet Centers/VAMC health service pages and a URL field for spotlight/link teasers on VAMC health system pages. I was under the impression that these use 2 different Drupal modules and needed to be labeled differently–but is that really true? (I may be thinking of other content types or specific cases I've work on in the past.)

My preference would be that both fields be labeled "Link" and have this help text:

Link Start typing to find content or paste an internal VA.gov URL and click on the suggestion below. If you paste a URL, the link must begin with a /, for example '/example-link'.

davidmpickett commented 7 months ago

I have not had capacity to do a review of the Content Model implications here. That work will block this ticket being actionable by a Drupal engineer. In the past, I have been able to do that kind of review at the front end of the same sprint that a Drupal Engineer picks this up, but given the other demands on my time right now, it would probably be better to have that as a discrete ticket.

@jilladams I need you to be PM on this epic so I can be Content Modeler. This might be one of our first examples of tradeoffs we talked about with me as UX Lead / temp Facilities PM

jilladams commented 7 months ago

Created #17724, marked as a blocker, queued for refinement.