department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

[UX - TESTING] Test Sitewide-managed apps/features/products against a 640px breakpoint #17762

Closed FranECross closed 3 months ago

FranECross commented 5 months ago

Status

[2024-05] 768 deprecation has no listed date. We've deprioritized this effort until it's clear that it's a priority with a timeline. [2024-04-25] This will be unblocked by the work in Sprint 2 wherein the FE folks will stand-up a test environment for testing the new breakpoint, so moving it into Ready for Jordan's consideration for Sprint 3.

Description

The Design System Team will be deprecating the 768px breakpoint and adding a 640px breakpoint (tentatively) in mid-August.

We need to ensure this change doesn't adversely affect any Public Website managed features/apps/products, and Jordan has offered to test the Public Websites products/apps/features at the 640px breakpoint to identify any issues.

User story

AS A PO/PM for Public Websites apps/features/products I WANT to ensure we accommodate the deprecation of the current 768px breakpoint and addition of a new 640px breakpoint SO THAT Veterans, their caregivers, family and survivors continue have a good experience when in VA.gov

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

Facilities products are audited for 640 breakpoint impact

Public Websites

Other

FranECross commented 5 months ago

@chriskim2311 @randimays Jordan mentioned having ya'll put the new 640px breakpoint on a lower environment so she can then test our products against it. Do you just need a basic ticket asking for this, with AC that Jordan is able to access the test against it? Thanks in advance!

randimays commented 5 months ago

@FranECross Yes, a basic ticket would be good 👍🏻 thanks!

FranECross commented 5 months ago

Thanks, @randimays! I saw your questions to Micah and used info from the Slack thread to create this ticket.

@jilladams I'll still broach this to the PO COP, but wanted to get ahead of the game by creating these tickets, since I don't really see any way to get around at least spot checking/testing. cc @thejordanwood

davidmpickett commented 5 months ago

In UX Sync, we discussed that this is not ready to move yet because DST has not provided a branch where breakpoint changes are staged

jilladams commented 5 months ago

Got lost in the sauce live: #17775 tracks having FE stand up the branch, and that ticket is already listed here as a dependency. 🤦‍♀️

jilladams commented 5 months ago

Also: That ticket is going to move in Sprint 2, very likely. So: back to needing to refine this for Fac vs. PW and whether both can happen.

jilladams commented 5 months ago

FYI: I updated this story to span both PW & Facilities, and borrowed the check list of products from the typography audit ticket.

jilladams commented 5 months ago

(Some of the ACs per product may be silly for a breakpoint check, e.g. the various Cerner CTA widgets. If we know one of them looks ok at this break, they probably all do. Feel free to push back or suggest AC adjustments as necessary.)

davidmpickett commented 5 months ago

Given the scope of the products to review this is an 8 by default. I could see this being just a 5 if there are very few issues to document.

FranECross commented 5 months ago

Thanks, Dave! Leaving it an 8 since there are so many products/apps/pages to look at makes sense.

jilladams commented 5 months ago

We are going to push this from Facilities SSprint 3 to June (after typography). When it comes around, Amanda noted she's happy to help out.

FranECross commented 3 months ago

Per Jill Adam's note in the Epic: Closing this. We've decided we'll work on adopting the 640 breakpoint for all our products, when we move everything over to Accelerated Publishing templates.