department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

[FE 640px] Stand-up a branch with 640px breakpoint to enable testing #17775

Closed FranECross closed 3 months ago

FranECross commented 6 months ago

Status

[2024-4-17] Testing won't begin until Sprint 3.

Description

In support of Jordan testing the upcoming new 640px breakpoint, make a branch with the $medium-screen variable changed to 640px. An assumption broached to Micah here in Slack, is that all of the web components will be adjusted from that also.

User story

AS A Veteran, their caregiver, family member or survivor viewing products, features and apps (that the Public Websites Team manages) at a 640px breakpoint I WANT to be able to view and utilize all features (buttons/links/etc.) everything without issues SO THAT I have an excellent experience in VA.gov and my trust in the website is not eroded

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

jilladams commented 5 months ago

We have opted to deprioritize the breakpoint audit until after typography review.

randimays commented 5 months ago

@jilladams @FranECross Should this be in the "Ready" column instead?

jilladams commented 5 months ago

good call, moved back to Ready and it's already tagged later into Sprint 5.

jilladams commented 4 months ago

https://dsva.slack.com/archives/C03R5SBELQM/p1717088433049829

The new 640px breakpoint is now available for use. In order to use it, teams can follow the same convention currently in place for accessing shared Formation variables by importing our design tokens into your application's stylesheet:

@import "~@department-of-veterans-affairs/css-library/dist/tokens/scss/variables";

and then using its token name, $tablet , for example:


    .usa-content,
    .va-nav-breadcrumbs {
      padding-left: 0.9375rem;
      padding-right: 0.9375rem;
    }
  }```

Not sure the implications for us standing up an environment to test in, when the time comes, just noting the guidance while it's fresh.
FranECross commented 3 months ago

Per Jill Adam's note in the Epic: Closing this. We've decided we'll work on adopting the 640 breakpoint for all our products, when we move everything over to Accelerated Publishing templates.