department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

When VAMC Health Services are created, the revision timestamp on related VAMC Facility is incorrect #17808

Open jilladams opened 5 months ago

jilladams commented 5 months ago

Description or Additional Context

In the aftermath of #17587, we have a new regression, circling around March 2, 2024, 7:28 am. (CT)

Expected behavior

When a new VAMC Facility Health service is created, it is associated with a VAMC Facility. That related VAMC Facility should get a Revision log for the creation timestamp. This should happen when a new service is created related to the VAMC Facility, by way of the corresponding entity reference.

Current behavior in prod

When a new VAMC Facility Health Service is created, we suspect that it is somehow bypassing the normal process and is using the timestamp of the previous node revision rather than creating a new revision / timestamp.

Updated date not matching the revision log

Content view (/admin/content)

Palm Bay VA Clinic was updated on April 8, 2024

Screenshot 2024-04-10 at 17 42 17

Recent changes

No April 8 revision is shown. Screenshot 2024-04-10 at 17 42 35

Comparing revisions

The only difference is the addition of a health service. Screenshot 2024-04-10 at 17 43 28

VAMC facility health service creation

The time at which the health service was created is the same time at which /admin/content lists the facility as being updated. The facility is updated when a new service is created that is related to it by way of the corresponding entity reference.

Screenshot 2024-04-10 at 17 50 17

Acceptance Criteria

jilladams commented 5 months ago

@omahane is this sort of the same issue, but for Vet Centers? https://github.com/department-of-veterans-affairs/va.gov-cms/issues/15125

jilladams commented 5 months ago

THis might also be true for VBA.

jilladams commented 5 months ago

May also apply to Vet Center services in the world after removing the inline entity form.