search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
78 stars 59 forks source link

Outreach Materials: upgrade to va-icon #17825

Open randimays opened 3 weeks ago

randimays commented 3 weeks ago

Description

The Design System team is deprecating Font Awesome and encouraging teams to use <va-icon> where possible by the end of May 2024. Slack post here: https://dsva.slack.com/archives/C03R5SBELQM/p1710776364414359

We need to convert all usage of <i> in this application to <va-icon> to align with the icons in DST's library here: https://design.va.gov/foundation/icons

<va-icon> guidance in Storybook: https://design.va.gov/storybook/?path=/docs/uswds-va-icon--default

Engineering notes

Icons to be converted:

  1. https://github.com/department-of-veterans-affairs/content-build/blob/267e8c01b81d33570a2d97cf9f71e93b23f996fb/src/site/layouts/publication_listing.drupal.liquid#L210
  2. https://github.com/department-of-veterans-affairs/content-build/blob/267e8c01b81d33570a2d97cf9f71e93b23f996fb/src/site/layouts/publication_listing.drupal.liquid#L219
  3. https://github.com/department-of-veterans-affairs/content-build/blob/267e8c01b81d33570a2d97cf9f71e93b23f996fb/src/site/layouts/publication_listing.drupal.liquid#L232
  4. https://github.com/department-of-veterans-affairs/content-build/blob/267e8c01b81d33570a2d97cf9f71e93b23f996fb/src/site/layouts/publication_listing.drupal.liquid#L183

User story

AS A PO/PM for products/features/applications managed by the Public Websites team I WANT our features/products/applicates migrated to va-icon where appropriate SO THAT when the migration to va-icon and deprecation of Font Awesome takes place, there won't be degraded Veteran-facing experiences in VA.gov.

Quality / testing notes

Acceptance criteria

randimays commented 1 week ago

Mid-sprint update: we have been blocked on using va-icon in content-build since 4/19. DST is still working on a fix; it's not clear whether it will be released before the end of our sprint, but flagging the risk here.