department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
96 stars 70 forks source link

VBA QA: Accordions on VBA Prepare for your visit should be conditional #17852

Closed laflannery closed 1 week ago

laflannery commented 4 months ago

Description

On VBA, the "Expand all" button currently display when there are no accordions because there is no conditional written. While there is content that will be required for this section so there should be no VBA pages published without Prepare for your visit content, we should make sure this is conditionalized properly.

Screenshot 2024-04-11 at 10 35 15 AM

Eng notes

  1. This field is not mechanically required in Drupal, but VBA facilities won't be approved for launch / publish without this data present
  2. If the accordion is single select (only 1 accordion can open at a time), Expand All does not appear. But any other setting, Expand All always appears. Laura will raise with the DS.

This AC is blocked by DS component fix for 2 above:

Acceptance Criteria

jilladams commented 4 months ago

Expand All may be part of the Accordion component, so we need to figure out if we have control over show / hide when there's more than 1 accordion.

jilladams commented 4 months ago

Not launch blocking, but should do before we walk away from MVP.

Agile6MSkinner commented 2 months ago

@laflannery The description says that you would raise a blocker with DS. What was the outcome of that?

laflannery commented 4 weeks ago

I haven't done this yet - it's low priority but also isn't a blocker for this ticket. The 3 current AC should be able to to be completed without any additional functionality needed from the component

Agile6MSkinner commented 1 week ago

Technically there is an edge-case risk, but there are multiple systems in place that would prevent this from coming up. Will close as not planned.