VBA final design review

[jilladams]

When component adoption is complete for VBA, we need to design review the template with pre-populated data for several cases. This should start as a FE exercise to ensure that we are:

• Using DS components wherever possible
• Not using custom code and classes, unless absolutely necessary
• Build is as compliant with Figma designs as possible

When those thing are confirmed, FE should tag Design for further design review for any final changes.

ACs

• [ ] Test content is populated for VBA
  • [ ] This would increase the size of the is ticket, if auto generated content ticket is not done first #17969
• [ ] FE engineering has reviewed the build to ensure:
  • [ ] DS components are used wherever possible
  • [ ] No custom code and classes are in use, unless absolutely necessary. If they are, their use is flagged for design review
  • [ ] Build is as compliant with Figma designs as possible
• [ ] UX has reviewed the build from this point for:
  • [ ] Design compliance
  • [ ] Case by case review of any spots where custom code / classes would be required to achieve the Figma designs, to determine if that's preferred or if designs should change to accommodate pure DS use
  • [ ] Tickets are filed for FE required updates

[jilladams]

Laura started a more granular review, but I paused her. Her notes from just Heading review are in this ticket, but her notes are not comprehensive: #17927

A lot of what she found was happening bc the VBA templates use a lot of pre-existing VAMC code. Once we've adopted components (in #17095) and removed custom classes / code, some of her notes may be outdated.

The forest for the trees here is: VBA build needs to match VBA design, we need to confirm that it does with a variety of data, and we need to use the DS out of the box wherever we can. (Or advocate to the DS to provide anything we require that prevents us from using the DS out of the box.)

[jilladams]

FE points = 3 We need UX points

[davidmpickett]

From UX Sync yesterday, it doesn't make sense to do a holistic design review until all the existing design issues have been addressed. I have added them as blockers to this ticket