VAMC non-clinical services have required fields that are not applicable to them

laflannery commented 2 weeks ago

Describe the defect

With the new update to Service Locations, the VAMC non-clinical service type in Drupal has required fields that are not applicable to this content type nor does any of this information display on the front end. This creates a poor editor experience because of the steps explained below:

To Reproduce

Steps to reproduce the behavior:

Go to a non-clinical service on the SL Tugboat, example
Click on the 'Edit' tab
Scroll down, add a Revision log message and try to save the content
If this is the first time this particular node has been edited since the updated fields have been added, you will see an error message indicating that there are 4 errors:
This is because these are all new, required fields but they have no content yet.
The editor will need to select options and/or add content for these fields before being able to save this node
However, these particular fields do not apply to non-clinical services. Also, even if I do happen to select options other than "No" for these fields, nothing shows on the Front End site.

This makes for a frustrating editor experience because we are preventing them from saving their content with non-applicable fields.

AC / Expected behavior

[ ] The user experience for non-clinical services has been adjusted
[ ] There are no regressions for the UI on VAMC Facility health services
[ ] There are no regressions on the UI on VBA Facility health services

Additional context

A possible, quick and dirty solution, could be to update the migration to default the non-clinical services to the null option for these particular fields. This could potentially alleviate some of the frustration here and not impact the planned launch timeline. A longer-term solution could then be discussed for post-launch.

jilladams commented 2 weeks ago

@omahane this ticket is the topic Laura brought up at the end of UX sync today. I would love to get your thoughts:

She suggested data migration updates to set null values for the non-clinical services, to fix this UX. Does that seem light or heavy?
We talked on the call about the fact that these fields from the Service Location paragraph will likely never matter for non-clinical services. They'll be exposed in this location on Drupal, but won't map to anything in FE templates. Laura and I think it's true that the paragraph type is one size fits all, and we can't hide these fields on non-clinical services. Could you confirm that, or correct us if that's wrong, if you know?

cc @davidmpickett @aklausmeier

davidmpickett commented 2 weeks ago

Rather than updating the migration I had proposed handling this as a bulk update https://github.com/department-of-veterans-affairs/va.gov-cms/issues/17515

davidmpickett commented 2 weeks ago

I would suggest closing this as dupe of 17515 and continuing this conversation there. It’s the same core issue and already has additional screenshots and notes on limitations

jilladams commented 2 weeks ago

Thanks, Dave. Closing.

department-of-veterans-affairs / va.gov-cms