department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
79 stars 59 forks source link

VBA Service Accordion IDs should be plain language #17986

Open laflannery opened 1 month ago

laflannery commented 1 month ago

Description

Can we improve the IDs of the VBA service accordions? For example, the ID for home loans is "vba-service-item-1131-" instead of on VAMC the ID would have been "home-loans". This appears to be coming from the taxonomy ID rather than the name:

Screenshot 2024-05-29 at 4 51 26 PM

This ID is used to allow editors to create direct, deep links specifically to individual accordions. Rather than having to send a link to a page and then tell the user to scroll down and find the correct accordion. Using these IDs/deep links is a much more useful and efficient way to get info to a site user.

However, the way the IDs on the VBA accordions are set up, it is harder, less intuitive to create a deep link and could potentially lead to incorrect links in the future - it's much easier to get a random number wrong than it is when you are typing a common word to create a link. So I'm curious if we have the ability to change this and set them up they way they are on VAMC?

VBA Screenshot 2024-04-29 at 9 25 49 AM

VAMC Screenshot 2024-04-29 at 9 26 38 AM

Acceptance Criteria

davidmpickett commented 3 weeks ago

What's interesting is that this is true even for Services that are shared with VAMC and Vet Centers. For example Veteran Readiness and Employment Programs is correctly gets a legible ID on VAMCs. But that doesn't translate to VBA instances of the same service.

Screenshot 2024-05-31 at 2 06 35 PM

So this seems to be not tied to the Term in the Service Taxonomy, but more likely tied to the VBA Facility Service content type. I'm unclear on whether this is something that we fix on the Drupal side (I know some URL stuff is handled that way) or as part of Content Build?

davidmpickett commented 3 weeks ago

Suggest launch blocking, not staging review blocking

jilladams commented 3 weeks ago

Tagged as both Drupal & FE until we understand who owns the fix.