department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
96 stars 70 forks source link

[Breakpoints] No Left/Right padding on smaller breakpoints on Outreach and Events #18102

Closed laflannery closed 5 days ago

laflannery commented 3 months ago

Description

On smaller breakpoints (768 and below), some event detail pages don't have any left/right padding on the side of the screen, not all though, just some. For example:

Also, the Outreach and Events page needs a style adjustment. Between page widths 768px 640px - 1014px, the content touches the left edge of the page, causing legibility issues. We should make the styling for this page consistent with other full-width pages on va.gov. See these examples: https://www.va.gov/find-forms/

Acceptance Criteria

randimays commented 3 months ago

This is a dupe of https://github.com/department-of-veterans-affairs/va.gov-cms/issues/16416 I think. We can combine description details there if you like

laflannery commented 3 months ago

@randimays This is about detail pages, I think the one you made is about the landing page specifically? I don't disagree that they might be able to be combined because maybe they are solved the same way but I just want to be sure I'm reading that other ticket correctly before I combine them

randimays commented 3 months ago

@laflannery Yes, mine was specific to landing pages. I think we can combine all the weirdness into one ticket (landing pages and detail pages) 👍🏻

FranECross commented 5 days ago

Closing as a no op. Taken care of in #16416