Double quotes in a va-link (Staff Name) field are not encoded properly for the FE

[ian-sears]

Describe the defect

When an editor uses double quotes in a Staff Profile first or last name field, this causes the name to not be displayed on the Front end

To Reproduce

Steps to reproduce the behavior: Maybe do this on a Tugboat so we don't break this again on Prod:

1. Go to a staff profile page, for example Charles "Dave" Collins
2. Change the single quotes to double quotes for his nickname "Dave"
3. Save the Node.
4. After Content Release, the page at Salisbury Health Care > Leadership displays the name as only Charles.

AC / Expected behavior

• [ ] If double quotes are used in the Drupal Staff field, these are encoded properly in the FE build
• [ ] The entire First and Last Name content should display on the Front end
• [ ] QA Review

Screenshots

I will try to capture a screenshot to add to this if possible.

Additional context

• The reason this displays correctly on the staff detail page and not the listing page is because the listing page uses the va-link component and the detail page is just plain text. The link needs to be encoded. This was done recently on Facility names. Slack thread here that mentioned the encode liquid filter that should be used to resolve this
• This is also a larger issue in general within Drupal that the CMS team I think should potentially look at as this is happening in multiple fields
  • Facility titles (we already handled this)
  • Operating status More info field - #17134
  • Alt text - #17444

[srancour]

Charles is no longer listed on that page. Another page to look at is Spokane Health Care Leadership with James "Shep" Speight

[srancour]

They changed James to "James (Shep) Speight" another leadership member is Thomas "Zach" Orr who's on the VA West Palm Beach Health Care Leadership page. It does look like the name may being populated is from the text field in the va-link element because it is in fact closing that field with the quotes for this instance.

On the Sergeant Ernest I. "Boots" Thomas VA Clinic facility it looks like the text field is escaping the quotes using &quot on the Locations page.

Staff profiles being referenced in pages other than the leadership page seem to not be using the va-link and instead are using a tags so the quotes are working there for things like Mary "Heather" Levy BSN, RN on the Charleston Healthcare Oncology Meet the Team section.

Also, when a staff profile doesn't have a biography it seems that it doesn't break as well like in the case of Robert "Robbie" Davis on the VA North Florida/South Georgia health care Patient advocates page. This is also true for leadership pages when the person doesn't have a biography like William "Billy" Irwin MD on the VA Marion health care Leadership page.