department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
79 stars 59 forks source link

[Events] [UX] SPIKE Understand date input error message behavior for Events filter #18197

Open FranECross opened 1 month ago

FranECross commented 1 month ago

Status

[2024-06-18] Carissa contacted the DST, and she submitted a bug ticket for them to fix this issue. Fran to retest after the DST ticket has been released, and then we can close this as a no op.

Describe the defect

When switching between Specific Date and Custom date range filters, entering only the end date (and reusing the existing start date that is prepopulated after setting Specific date), results in validation error bars, but no validation error messages.

Also, if the user chooses Specific Date, or Custom date range, then kicks off the search without entering anything, the messages don't display.

Please check with the Design team to determine if their component/date fields and error messages are performing as planned. If so (and if not), do they have any plans to update?

Steps To Reproduce

Choose Specific Date Steps

  1. Go to https://www.va.gov/outreach-and-events/events/
  2. Click on Filter by: Choose specific date
  3. Submit filter on empty form
  4. Filter shows red error bars, but does not show an error message (and should)

Choose Date Range Steps

  1. Go to https://www.va.gov/outreach-and-events/events/
  2. Click on Filter and choose Custom date range
  3. Choose/enter a Start date
  4. Don't choose/enter an End date
  5. Click Apply filter
image.png image.png

Expected behavior

Any validation error bar is accompanied by a validation error message.

User story

AS A Veteran, their family member, caregiver and/or survivor who encounters a error when filtering events by date ranges I WANT to see a helpful error message when I encounter an error SO THAT I know next steps and can then successfully filter the events by date range.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

FranECross commented 1 month ago

@davidmpickett @thejordanwood A new UX ticket to be added to UX Sync agenda. Thanks!

davidmpickett commented 1 month ago

@cmmerrill This might a good first ticket for you to work on. It's just about providing UX microcopy AND it's related to events

cmmerrill commented 1 month ago

Interestingly @FranECross , the error messages display if you click into a field, but don't provide a specific month/day/year. Additionally if you miss one of the fields.

Screenshot 2024-05-23 at 10 59 28 AM Screenshot 2024-05-23 at 10 59 44 AM Screenshot 2024-05-23 at 10 59 58 AM Screenshot 2024-05-23 at 11 00 29 AM

davidmpickett commented 1 month ago

@FranECross Based on @cmmerrill's initial exploration, we think that the issue here is not about the error text not existing, it's more of a conditional logic problem of the error text not always displaying. So I think this might need to go to Front End for investigation/ refinement.

FranECross commented 1 month ago

@davidmpickett @cmmerrill Apologies, it appears I didn't add to the AC all scenarios described in the Description. The one that still doesn't display an actual error message (other than 'Required' is if the user chooses 'Filter by Custom date range', enters a beginning date, doesn't enter an ending date, and clicks Apply filter

image

davidmpickett commented 1 month ago

Probably an issue with the Design System Team component - @cmmerrill to connect with Design System to investigate

cmmerrill commented 1 month ago

I shared this Mural documenting the logic issue with DS team--they already have a related ticket re: error message overrides, so will assess and handle the update of the logic issue at the same time. This ticket can be closed or de-prioritized as appropriate, and I'll file a defect. @davidmpickett @FranECross

Link to Mural

Link to DS Slack discussion

Screenshot 2024-06-07 at 3 12 55 PM
FranECross commented 3 weeks ago

Thanks, @cmmerrill !! I'll scoot it to a holding column so we can retest after the DS team implements their changes. Appreciate you getting this info!