department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 70 forks source link

Tugboat / CMS not picking up changes for vets-website on a content release #18208

Open randimays opened 2 months ago

randimays commented 2 months ago

Description

When I create a Tugboat, go to its CMS, and Release content with a specific content-build and vets-website branch created, I do not see the changes on the vets-website branch.

Example Tugboat: https://tugboat.vfs.va.gov/6657427f17e38363d33f18eb

Related PR: https://github.com/department-of-veterans-affairs/vets-website/pull/28812

Web view for this Tugboat after the content release for the vets-website branch: https://web-luqe8lbtaxvgujvwf6rw4qgehzg6tugm.demo.cms.va.gov/search/

Content release build logs: https://cms-luqe8lbtaxvgujvwf6rw4qgehzg6tugm.demo.cms.va.gov/sites/default/files/build.txt

How to verify that it's not working as expected

The PR linked above changed the links in the Web view under "More VA search tools" to use the design system web component for the links.

This is how the DOM for these links looks when the code is run locally:

318520208-b4351238-a19d-446f-946f-efd20d14c956

This is how the DOM looks on the Tugboat (where the changes are not being picked up):

Screenshot 2024-05-29 at 2 08 35 PM

This has been happening to me since the content release for vets-website became available. I have never been able to see vets-website changes reflected in a Tugboat.

Prior work to enable vets-website branch builds on Tugboat

ACs

jilladams commented 1 month ago

@gracekretschmer-metrostar FYI Sitewide likely needs to bump up priority on this. This is affecting our ability to effectively preview VBA Regional Offices before our Front-end launch.

For context:

So Tugboats are the only place we can preview:

Our vets-website changes are merged to main, so we don't need specific branch capabilities. But we do need Tugboat to serve up vets-website main properly.

We are scheduled for a Staging Review of ROs on July 2 and plannign for Governance team to review our work in Tugboat. Right now Tugboat can't effectively display the state of our work though. 😬

cc @EWashb @Agile6MSkinner @mmiddaugh for awareness

jilladams commented 1 month ago

Related recent thread with some examples of what we're seeing: https://dsva.slack.com/archives/C0FQSS30V/p1718987566280199

jilladams commented 1 month ago

Follow up: we figured out that when a Tugboat initially builds, or when you run Content Relase within Drupal using the Default setting, it may not grab the actual latest state of main for content-build / vets-website. To get that working correctly, in Content Release, you have to "select a different branch" for each repo, and specify main. Then it'll build with main.

I think it's still true that Tugboat isn't able to successfully grab the state of any alternate branch besides main for vets-website.

But anyway: our Staging Review for VBA is unblocked since we got main to build correctly.