department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
79 stars 59 forks source link

Heading structure in Service Accordions is not helpful to user #18222

Open laflannery opened 1 month ago

laflannery commented 1 month ago

Description

This is somewhat related to the ticket regarding "Appointments" showing with no content but ultimately because we have so many headings, and it's all connected to other templates, they aren't hierarchical like they should be.

For example, the phone number under appointments should be an h6 but there is really no reason to be going that far down, which is why I'm advocating to just get rid of these headers here - they aren't necessary.

The bigger issue is that having the heading level the same is potentially going to create more confusion because it's muddying the relationship of these elements

Acceptance Criteria

davidmpickett commented 1 month ago

This might need to be split into a few tickets to cover the various places where we are using headings that we want to move toward bold/strong text instead.

- VBA main page template - Should be pretty small scope and could be launch blocking - I think Location and Contact information is the main area to fix - Address, phone numbers, and office hours

- Other places on VAMCs - Etc.

Agile6MSkinner commented 1 month ago

To Dave's comment, let's split out another ticket for the Man Page Template, which will will consider launch blocking. This ticket will stay in the backlog for fast follow/national rollout. I will work with @laflannery and/or @davidmpickett to create the ticket.

laflannery commented 1 month ago

To be clear, this ticket is referring to the heading structure within the accordions, as described in the description above. The headings outside the accordions, while eventually they could probably be improved, they aren't hindering the user's ability to understand the content.

Agile6MSkinner commented 1 month ago

After talking with @laflannery we are moving this to the national rollout epic because it is related to a more global issue and will require a lot of design discovery. It's not a high-priority issue, it just looks bad.

@thejordanwood Do you have an epic that this could be included in or a design discovery ticket that we could set as a pre-req?

davidmpickett commented 1 month ago

@thejordanwood Do you have an epic that this could be included in or a design discovery ticket that we could set as a pre-req?

davidmpickett commented 1 month ago

To be clear, this ticket is referring to the heading structure within the accordions, as described in the description above. The headings outside the accordions, while eventually they could probably be improved, they aren't hindering the user's ability to understand the content.

Updated ticket title to reflect this scope

Agile6MSkinner commented 4 days ago

@davidmpickett @thejordanwood Do we think that the work described here is discrete or will it be taken care of in other issues/tickets/epics?

davidmpickett commented 4 days ago

@davidmpickett @thejordanwood Do we think that the work described here is discrete or will it be taken care of in other issues/tickets/epics?

To my knowledge this is the only place this work is documented in a ticket. This could potentially be a fix to make during AP template migration.