department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

Appt phone numbers are not displaying in the order they appear in Drupal #18228

Open laflannery opened 5 months ago

laflannery commented 5 months ago

Description

Phone numbers appear to be displaying on the FE in order by type (Phone, Fax, SMS, TTY) rather than in the order they were entered. Not sure if this matters.

Examples

  1. On a Service region

Screen shot of Drupal A third phone number was entered last: Screenshot 2024-05-29 at 4 47 56 PM

Screenshot of the FE But on the front end, the last phone number displays third: Screenshot 2024-05-29 at 4 48 48 PM

  1. On a Facility service

Screenshot of the FE In this example, I labelled all the appt numbers with the order they were entered in Drupal to make it easier to see a change in the FE display: Screenshot 2024-05-30 at 9 14 33 AM

Acceptance Criteria

Agile6MSkinner commented 4 months ago

Not entirely germane to this ticket, but shouldn't the fax number be wrapped?

laflannery commented 4 months ago

@Agile6MSkinner If you mean linked and clickable, no. You wouldn't click to auto dial this particular number, because it's for faxing not calling a person. So that's specifically why we do not want folks accidentally calling that number and getting that terrible dial tone.

jilladams commented 2 months ago

Per Eli, appointment and contact phone numbers are handled differently. True for both VAMC & VBA. There is FE code that iterates through phone numbers array, dumps it to an object where the order is not maintained. That logic would need to get updated to address this, and if would affect both.

Agile6MSkinner commented 2 months ago

@Agile6MSkinner need to put this in another epic

davidmpickett commented 2 months ago

I moved this to #17350