department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Vet Center incorrect heading structure in accordions #18242

Open laflannery opened 5 months ago

laflannery commented 5 months ago

Description

At the bottom of all Vet Center pages, there are 2 heading structure issues that should be resolved:

  1. The first issue is that all accordion titles should be h3s but the "How we are different" section has accordions that are h2s: Screenshot 2024-05-29 at 8 44 00 AM
  2. Second issue is, within this particular accordion, there is an alert that has an h2 heading. This should actually be an h4: Screenshot 2024-05-29 at 8 45 21 AM

Question

I would also make the case that this alert isn't necessary, this content can simply be added as a basic list on the page - putting it within the additional info component is adding additional clicks and complexity that isn't needed. Do we have the authority to change this format?

Acceptance Criteria

Agile6MSkinner commented 5 months ago

I'm moving this back to the backlog because it appears that there is design work that still needs to be done before we can point it.

laflannery commented 4 months ago

@mmiddaugh and possibly @aklausmeier In the ticket description I have a question that I think you might be able to provide insight on, I have provided the info/question here as well:

On each Vet center page, in the "How are we different" section, there is an accordion for "Am I eligible for Vet Center services as a Veteran or service member?". This accordion content has an alert with a header level defect currently. However I am curious if we even need to have this content in an alert. It's a simple bullet list and by adding this content in an additional info component within an alert just adds complexity that I don't think we need.

Do you know if we are able to remove this format and simply add the bullets within the content instead?

aklausmeier commented 4 months ago

I am in favor of pulling content out of hidden additional info components and don't see a need for the alert. Unless @mmiddaugh has historical context/prior decisioning for keeping this.

jilladams commented 3 months ago

The current body of this ticket is isolated to 2 things:

  1. Fixing accordion headers to become h3
  2. Changing the alert header within the eligibility accordion from h2 to h4

Comments from Laura / Amanda in ticket say:

I don't see any design calls that need to be made. @mmiddaugh if you can advise about the Alert, we can update ticket and refine this. Moving to Backlog until we get that clarified.

Also noting: this ticket isn't currently in an epic. I don't think it makes sense to tack it onto Vet Center 2.0, so didn't do that.

laflannery commented 1 month ago

@Agile6MSkinner Tagging you because I would like to talk about this in our meeting tomorrow and this way we can easily find it