department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
79 stars 59 forks source link

Vet Center incorrect heading structure in accordions #18242

Open laflannery opened 1 month ago

laflannery commented 1 month ago

Description

At the bottom of all Vet Center pages, there are accordions that come from centralized content and this is causing an incorrect heading structure:

  1. The first issue is that all accordion titles should be h3s but for some reason one of them is an h2: Screenshot 2024-05-29 at 8 44 00 AM
  2. Then, within this accordion, there is an alert that has an h2 heading. This should actually be an h4: Screenshot 2024-05-29 at 8 45 21 AM

I would also make the case that this alert isn't necessary, this content can simply be added as a basic list on the page - putting it within the additional info component is adding additional clicks and complexity that isn't needed.

Acceptance Criteria

Agile6MSkinner commented 1 week ago

I'm moving this back to the backlog because it appears that there is design work that still needs to be done before we can point it.