department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

[Aging Content MVP] Notification emails need to be able to limit sending to specific users/email addresses #18311

Closed FranECross closed 3 months ago

FranECross commented 4 months ago

Description

In order to ensure appropriate people other than the last published editor receive the aging content notification emails, we want the ability to limit sending the emails to specific users/email addresses. This will enable us to expand our use of aging content notifications to cover content not yet published that needs review, content that has been edited by someone without permissions to publish, and managers of editors who published content.

This is to ensure emails aren't sent to the 'bot' last editor, when the system makes a change.

User story

AS A CAIA member, or a manager of editors I WANT to receive emails alerting me that content needs to be archived, reviewed, published, or updated SO THAT I can take appropriate actions.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

jilladams commented 3 months ago

@dsasser @jv-agile6 could y'all add some detail about where we're at on this ticket for current sprint?

dsasser commented 3 months ago

@dsasser @jv-agile6 could y'all add some detail about where we're at on this ticket for current sprint?

The work is complete, and tests have been added and updated as necessary. I planned to go over the git commit->PR workflow with Jerry tomorrow in order to get some muscle memory going in that direction, but there aren't any flags or concerns with getting this over the line by sprint end.

jilladams commented 3 months ago

Deployed to prod. Poked at the config a bit https://prod.cms.va.gov/admin/config/workflow/eca/aging_content_warn_fwb/edit but I'm not certain how to verify. (We def need to get this sucker documented for future generations, somewhere. )

FranECross commented 3 months ago

@jilladams I think that the remaining ticket "send notifications at midnight" needs to be released too before it can be tested? (@dsasser , is this true?I have the KB article ticket assigned to me and will make a point to draft it next week and then will ask Daniel to PR review.

dsasser commented 3 months ago

@jilladams I think that the remaining ticket "send notifications at midnight" needs to be released too before it can be tested? (@dsasser , is this true?I have the KB article ticket assigned to me and will make a point to draft it next week and then will ask Daniel to PR review.

@FranECross @jilladams At this time, Aging Content is deployed and enabled for FWB notifications. No other work needs to go out. Emails should start going out at midnight tonight. Apologies for the confusion, a couple tickets seem to have dropped off my board (a filtering issue on my end I'm sure), and that caused me to miss updating statuses.