search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
79 stars 59 forks source link

Deprecate facilities-api V1, after LH V0 deprecation #18314

Open jilladams opened 3 weeks ago

jilladams commented 3 weeks ago

From onsite: when LH V0 is deprecated, we need to also deprecate facilities-api V1.

IIR may be able to help with this, need to check with them.

Swagger docs need to be updated to indicate a sunset date.

dsasser commented 3 weeks ago

Discovery note: The v0 Facilities API isn't showing up in Swagger UI, but the Facility heading is present there:

Screenshot 2024-06-12 at 12 23 58 PM

The v1 Facilities API is showing in Swagger:

Screenshot 2024-06-12 at 12 24 35 PM
eselkin commented 2 weeks ago

@dsasser There is no v0 Facilities API endpoint (they didn't make one), they just made v1. Now we're on v2 (of /facilities_api/v2/va).

But /v1/facilities/va is the endpoint that's under even more scrutiny. The one we use for all Facilities calls is /facilities_api/v#/va not /v#/facilities/va. We need to get rid of /v#/facilities/va because nobody upkeeps it and we were given ownership of it. Also /v#/facilities/... doesn't have PPMS support so it's less all-around useful

jilladams commented 2 weeks ago

Pinged Pete and cc'ed Michael (in DM) to see if IIR may have capacity: https://dsva.slack.com/archives/C078VEZCMJS/p1718907592194749