department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

[Analytics] [Campaign Landing Pages] Custom GA events removal & adoption of "action link" va-link component w/analytics #18345

Closed FranECross closed 3 months ago

FranECross commented 4 months ago

Description

The 'action link' va-link component is being enhanced (and will be available soon) to provide the destination URL in its built in analytics, and when released, can be used for Campaign Landing Pages, allowing us to remove custom GA code.

User story

AS A PO/PM managing the Campaign Landing Pages I WANT to (where appropriate) adopt the 'action link' va-link component, its baked-in analytics, and remove the custom GA events SO THAT extraneous code is removed and only the events needed will be triggered.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

randimays commented 3 months ago

Pulling in as stretch for Sprint 6.

randimays commented 3 months ago

@FranECross The downloadable resources links cannot be converted to va-link yet because they are blocked by this accessibility defect: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/2817

Do we want a separate ticket to track when this defect is complete, and then remove the custom events / convert to va-link?

randimays commented 3 months ago

Re: the comment to Fran above

I cut a new ticket for us to convert download links to va-link once the DST defect is completed and released: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/18415

Otherwise, I have validated these changes successfully in production. I'm closing this ticket as complete.