department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

[Analytics] [Header] Custom GA events removal & adoption of va-link component w/analytics #18347

Closed FranECross closed 3 months ago

FranECross commented 4 months ago

Status

[2024-07-15] Closing this ticket. We won't lose any analytics by waiting for the DS team to componentize the header/footer; they will take this on when they work on the header/footer. [2024-07-02] Messaged in Slack Micah and Carol about transferring this ticket (and one more) to them for when they work on components in the header. Added Transfer label.

Description

The va-link component has been enhanced to provide the destination URL in its built-in analytics, and can now be used for the 'mainstream' header.

User story

AS A PO/PM managing Public Websites products & features I WANT to (where appropriate) adopt the 'action link' va-link component, its baked-in analytics, and remove the custom GA events SO THAT extraneous code is removed and only the events needed will be triggered.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

FranECross commented 4 months ago

@laflannery @randimays to async to determine if the link will turn purple, which we don't want. We might no op this!

randimays commented 4 months ago

@FranECross @laflannery This ticket does not include white links. It's for links in the mega menu, so we shouldn't have any issues with purple links here (in fact all the mega menu links are hardcoded to be blue in any state). @FranECross Do we have a ticket for removing custom GA events on the homepage? That would be the work concerning white links (which I've started a thread with DST about here: https://dsva.slack.com/archives/C01DBGX4P45/p1718741463008769).

Also: we cannot convert these to va-links until after the injected header/footer code split is merged in (so we can time this ticket appropriately).

jilladams commented 3 months ago

@randimays @chriskim2311 FYI: per Michelle, moving this to top of Ready column:

Per Dave Conlon, the risk of not doing the Analytics issues discussed during planning this morning is the loss of data following the GA4 migration on 7/1. We deprioritized this work during planning due to the risk for double work but sounds we'll have to take that chance. can we add these relatively small issues to the sprint and/or top of the Ready column to be picked up when sprint commitments are complete?

randimays commented 3 months ago

Adding a note here that we shouldn't pick this up until injected H/F code split has been merged. We won't be able to adopt the web components into the header until then.

FranECross commented 3 months ago

Messaged in Slack Micah and Carol about transferring this ticket (and one more) to them for when they work on components in the header.

randimays commented 3 months ago

@FranECross Should this ticket be in Ready or are we transferring this to DST?

FranECross commented 3 months ago

@randimays Good point. Since we won't lose any analytics data by waiting, I'll move it to Admin or Backlog and mark blocked, and will update the status that it'll be transferred to DST. Thanks for the ping!