Update/remove incorrect divs in Facility locator search results

[laflannery]

Description

I recently found som <div>s that should be cleaned up in the Facility Locator search results listings:

• There are 2 empty <div>s with min-heights that are causing white space. These should be removed:
• The content should be wrapped using <p> tags instead of a <div> or a <span>. <div>s and <span>s are catch all tags that don't typically have any style and so the DST didn't give them any default style. For this reason, when the browser font sizes are set to something other than the standard, text within these tags does not resize properly
  • Using the current markup with <div> and <span>:

• Using <p> tags instead:

Acceptance Criteria

• [x] No empty div's are appearing in search results
• [x] Content is wrapped using <p> tags instead of more generic tags
• [x] Requires design review
• [x] Requires accessibility review

Accessibility review steps

To confirm the font is resizing correctly:

1. Go to the Facility Locator page /find-locations
2. Complete a search so that the search results appear
3. Within your browser, update your settings to the largest font size available.
   • Chrome: Settings > Appearance > Font size
   • Firefox: Settings > Language & Appearance > Fonts
   • Edge: Settings > Appearance > Fonts
4. Confirm all the text within each of the search result items increases in size correctly

[eselkin]

There's a span around the facility's title... It has no style attached but an occasional click/keypress tracking on VA Health facilities. I can remove it and put the click on the h3 title, but not sure we want to take on more intricate stuff here in this ticket.

[laflannery]

@eselkin From an accessibility standpoint, this <span> isn't doing anything bad. The heading tag has the proper font settings so it's resizing and scaling properly.

I don't disagree with you that this tag should maybe not be here from a clean up standpoint though. This might be a product call - if we expand this ticket or create a new one? @Agile6MSkinner

[Agile6MSkinner]

@eselkin @laflannery I'd rather get it done in this ticket if it doesn't create any issues. Would that cause it to roll over?

[eselkin]

So, I didn't see a response on how @laflannery wanted to handle this. I'll make an attempt to have this changed... however tests are currently a mess on v-w

[jilladams]

If you're blocked on the a11y feedback while Laura is out, we can also ask the A11y folks in #accessibility-champs, if that would be helpful.

[eselkin]

It all depends on whether they fix the mess that's going on with v-w presently. All unit tests are breaking now after some recent change they made and they even stopped the daily deploy. Also RI are broken completely.

The initial changes for the ticket are complete and were passed by Laura. It was the additional steps to remove the span around the h3 and make it clickable was in the second PR.

[laflannery]

@eselkin I believe my response above answers your question. Is there something else that you need from me on this?

[laflannery]

Confirmed on prod!