department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
96 stars 70 forks source link

[Analytics] [Homepage] Custom & Dupe GA events removal & web component upgrades #18416

Closed randimays closed 1 month ago

randimays commented 2 months ago

Status

[2024-07-23] [Fran] Duplicative events need to be removed. This ticket should be prioritized.

Description

The va-link web component's analytics now include link destination, and va-link-action has been released to the component library. We can now use baked-in analytics and convert to web components where possible on the home page.

User story

AS A PO/PM managing Public Websites products & features I WANT to (where appropriate) adopt the va-link or va-link-action component, its baked-in analytics, and remove the custom GA events SO THAT extraneous code is removed and only the events needed will be triggered.

Acceptance criteria

randimays commented 1 month ago

The <va-button> web component does not have log the current URL in the baked-in analytics. I've created a DST issue here: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/3091

Currently, that button has two events on it, both of them custom. Baked-in analytics are disabled for it.

event: "cta-button-click"
button-type: "primary"
button-click-label: "Create an account"

and

event: "homepage-create-account"
action: "Create an account"

@FranECross if you agree, I'm inclined to slim this down to one event, and we can circle back and use baked-in analytics once DST has time to add the current URL. Here's my proposed custom event for the time being:

event: "cta-button-click"
action: "Create an account button (homepage)"
FranECross commented 1 month ago

@randimays ☝🏼 I agree with slimming down. Thanks!

randimays commented 1 month ago

Thanks @FranECross! Do you mind creating a ticket for a follow-up to remove the custom event for the "Create an account" button once that DST issue has been resolved?

randimays commented 1 month ago

@FranECross I closed the DST ticket; nevermind creating an additional ticket for that. I checked with Jamie Stutt (analytics team) about adding link-origin to <va-button> and she said that the link-origin on baked-in analytics is duplicative. I was pretty sure we needed this value, but I guess not: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/3091#issuecomment-2253084083

randimays commented 1 month ago

Code is merged to production. Verified that only the web component baked-in events are firing now. Closing as complete.