search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

[Benefit Hub Detail Pages] "In this section" on mobile is missing the close button icon #18461

Closed randimays closed 3 months ago

randimays commented 3 months ago

Description

On benefit hub detail pages, the mobile screen's "In this section" menu is missing the close icon.

Example: https://www.va.gov/health-care/foreign-medical-program/ Where: mobile screens only

When the "In this section" hamburger icon is clicked, a submenu pops up. It should have a close button icon ("x"), but the icon is missing.

Slack thread for context: https://dsva.slack.com/archives/C01DBGX4P45/p1720190666776269

Screenshot 2024-07-05 at 10 06 37 AM Screenshot 2024-07-05 at 10 06 49 AM Screenshot 2024-07-05 at 10 06 55 AM

Engineering

The sidebar for these pages is created here in content-build: https://github.com/department-of-veterans-affairs/content-build/blob/main/src/site/components/navigation-sidebar-trigger.html#L11.

The only recent change to this file did not touch the close icon, but in case it's relevant: https://github.com/department-of-veterans-affairs/content-build/commit/9052cf032d9b10ff62b8981ec1afb87be8c14c9d#diff-1ab07f0975d329783885d946cefefcdcd0d0063c60197e4093a62b87f474a605

The close icon still exists in content-build in src/site/assets/img/icons, but that's not the path the styles are pointing to, so it's possible this may have been broken for a while?

User story

Describe the audience/user, enhancement or fix, and value / outcome desired.

AS A I WANT SO THAT

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

Consider

  • Design / Accessibility reviews
  • Collab cycle requirements
  • Device sizes (mobile first)
  • Documentation updates / Change management < - Content model documentation
  • Testing notes
randimays commented 3 months ago

Closing as a no-op per this Slack conversation: https://dsva.slack.com/archives/C01DBGX4P45/p1720190666776269. DST will own the fix.