search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 68 forks source link

LH V0: Deprecate the /v1/facilities/va endpoint in vets-api #18487

Open jilladams opened 3 months ago

jilladams commented 3 months ago

[2024-10-30] We cannot deprecate the whole legacy API client til we hear from Don (McCaughey?) on the mobile team. BUT: we may be able to deprecate this endpoint.

Description or Additional Context

Context: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/18351

Should decommission and remove not the library but the endpoint for /v1/facilities/va

The legacy Facilities API client/library in vets-api has an active endpoint that references Lighthouse V0. We need to deprecate that, now that LH V0 has been deprecated

The legacy API client is very minimally documented here: https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/facilities/facilities-api#legacy-facilities-api-client

The code lives here: https://github.com/department-of-veterans-affairs/vets-api/tree/master/lib/lighthouse/facilities

Acceptance Criteria

jilladams commented 6 days ago

We may find ourselves blocked from removing htis endpoint, depending on how Mobile handled the legacy API client V1 upgrade. But Eli will check, and if it can be removed, we will.