Open randimays opened 1 month ago
@laflannery This will need to be converted to a va-telephone
to use baked-in analytics. Do you know if we are ready to convert this link yet, or if this is blocked by the accessibility effort to fix va-telephone
?
@randimays I believe we can because it's standard, and we did it over on this example page: https://www.va.gov/resources/compare-va-education-benefits/. It's the non-standard numbers that weren't done because we aren't getting the info we need to pass the correct props and use the component properly so we left them as they are.
@laflannery Thank you. Not sure if you saw, I added some extra phone number links to the ticket. Worth mentioning none of these are hardcoded in the FE; they're all coming from Drupal. Still ok to convert them all?
Ah ok, so those are the ones where I'm not sure we can:
vanity
prop because I was told this only works with the last 4 digits as the vanity situation.international
prop to the component which will add it back but formatted properlyI realize this is a lot and I've thought about these various scenarios quite a bit so if you need more clarification on anything that I'm talking about or why I'm saying the things I'm saying let me know!
Thank you @laflannery this is definitely a lot to consider. @FranECross @Agile6MSkinner I moved this to Next Refinement because I think we need wider discussion about what to do with converting things to <va-telephone>
where we lack support. There will be other tickets blocked by these things too.
Adding here that we should also nail down exactly what can be input in Drupal so we know how blocked this is or how much overengineering we need to do on the FE to be able to convert to <va-telephone>
(and remove custom analytics events).
Also moving this one to the Backlog because this requires further discussion about va-telephone (same as #18506)
Status
[2024-08-19] [Fran] This requires further discussion about va-telephone (same as #18506) [2024-07-15] [Fran] Noting that this needs to be refined by the team in our next prefinement.
Description
The va-link web component's analytics now include link destination, and va-link-action has been released to the component library. We can now use baked-in analytics on the Resources & Support detail pages where the default contact is used.
Example pages
User story
AS A PO/PM managing Public Websites products & features I WANT to (where appropriate) adopt the va-link or va-link-action component, its baked-in analytics, and remove the custom GA events SO THAT extraneous code is removed and only the events needed will be triggered.
Engineering notes / background
Content-build templates:
This template is also used in Q&A, step by step, checklist templates as well as a few others.
Acceptance criteria