search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

[Analytics] [Navigation Links List] Custom GA events removal & web component upgrades #18521

Open randimays opened 3 months ago

randimays commented 3 months ago

Status

[2024-07-18] [Fran] Reviewed today; implementing component, adopting baked in analytics, remove custom analytics. No duplicate events firing. Not urgent.

Description

The va-link web component's analytics now include link destination, and va-link-action has been released to the component library. We can now use baked-in analytics and convert to web components where possible in links list navigation.

Engineering notes

Some exploration will need to be done to discover where this file / sidebar is used and how it differs from the sidebars present on benefit hub detail pages.

Code: https://github.com/department-of-veterans-affairs/content-build/blob/2cfe33c456bd3fb3dfcb961d0e975d74fcbb904f/src/site/components/navigation-links-list.html#L49

User story

AS A PO/PM managing Sitewide products & features I WANT to (where appropriate) adopt the va-link or va-link-action component, its baked-in analytics, and remove the custom GA events SO THAT extraneous code is removed and only the events needed will be triggered.

Acceptance criteria

chriskim2311 commented 1 week ago

Still looking for answers to if this is being used. Slack thread for more info: https://dsva.slack.com/archives/C52CL1PKQ/p1729796306070129