department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
96 stars 70 forks source link

FE: Display Vet Center Banner Image on Facility Pages #18711

Open Agile6MSkinner opened 1 month ago

Agile6MSkinner commented 1 month ago

Description

As a veteran who lands on a Vet Center facility page, I would like a VetCenter-specific banner imageto be prominently displayed at the top of the page so that I recognize it as something distinct from other VAMC facilities.

Figma Designs

Image will be added to Drupal in #18709

Implementation Details

The interface for fetching the Vet Center banner image

will utilize GraphQL. The query will be configured to retrieve the necessary fields for displaying the logo appropriately across various device breakpoints.

Example GraphQL query configuration (DO NOT use this verbatim, we do not know what the field is yet and it may come in a different format due to Centralized Content):

fieldVetCenterCCGraphic {
   entity {
        ... on MediaImage {
          image {
            alt
            title
            derivative(style: _32MEDIUMTHUMBNAIL) {
                url
                width
                height
            }
          }
        }
    }
}
### QA
- [ ] Accessibility Review
- [ ] Design Review
- [ ] Verify that image displays
- [ ] View on Desktop/tabet/mobile to verify breakpoints and resizing

Acceptance Criteria

eselkin commented 1 month ago

The interface is the GraphQL, it will just add something for the field they wire up to say like:

fieldVetCenterCCGraphic {
   entity {
        ... on MediaImage {
          image {
            alt
            title
            derivative(style: _32MEDIUMTHUMBNAIL) {
                url
                width
                height
            }
          }
        }
}

or something, depending on the sizes/configuration.

Agile6MSkinner commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @eselkin @jv-agile6 @chriskim2311 @randimays @dsasser

dsasser commented 1 month ago

@Agile6MSkinner I just noticed that the design system has something to say about logos:

Using custom logos for VA departments, offices, teams, sub-groups, special programs, initiatives, or events is not supported on VA.gov. This practice aligns with the requirements in the VA Graphic Standards and the Web Governance site.

I know there have already been design reviews for this change, so maybe I'm misinterpreting the meaning of "custom logo".

Agile6MSkinner commented 1 month ago

Interesting point, @dsasser. @aklausmeier any thoughts on that?

eselkin commented 1 month ago

I put a caveat on the example GQL query.

aklausmeier commented 1 month ago

@Agile6MSkinner We have an exception to use the Vet Center logo by someone on the web governance board IF it becomes the final design. The design is still in iterations and the logo has potential to be revised to an image. In my view this ticket is blocked by design.

randimays commented 1 month ago

@Agile6MSkinner Should this be in the Ready column? Looks like it is still blocked by the Drupal ticket.

Agile6MSkinner commented 1 month ago

It has been refined, so the story is ready, but it has a dependency that's listed: image

When looking at the board, it shows which tickets are blocked or blocking with these icons: image

eselkin commented 2 weeks ago

Will wait on determination of image status for Monday

laflannery commented 1 week ago

@eselkin the image annotations have been finalized. The image will be contextual and I have added the approved alt text into Drupal already

jilladams commented 3 days ago

From planning: