department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

[Analytics] [Dupe GA Events] Remove duplicate cta-button-click when the login modal is opened through 'Create account' #18767

Closed FranECross closed 2 months ago

FranECross commented 2 months ago

Description

Duplicate event(s) on FE Home Page identified and listed in (Randi's) this spreadsheet needs to be removed.

For this ticket, line item 33 identifies the following Element as having a duplicate event that should be removed.

Sitewide FE page: Home page

Element: When login modal is opened through "Create account"

Sitewide FE page: Home page

Element with custom events: When login modal is opened through "Create account"

User story

AS A PO/PM of sitewide products I WANT all duplicate events removed from our product's code SO THAT we aren't charged by Google Analytics twice for the 'same' event

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

randimays commented 2 months ago

This was taken care of in https://github.com/department-of-veterans-affairs/va.gov-cms/issues/18416, PR here. Closing as a dupe