department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

[Analytics] [Dupe GA Events] Remove duplicate promo-banner-event from the <va-promo-banner> element #18783

Closed FranECross closed 2 months ago

FranECross commented 2 months ago

Description

The duplicate event(s) on FE page Promo Banner identified and listed on line 47 in Randi's spreadsheet needs to be removed.

Sitewide FE page: Promo Banner

Element:

User story

AS A PO/PM of sitewide products I WANT all duplicate events removed from our product's code SO THAT we aren't charged by Google Analytics twice for the 'same' event

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

randimays commented 2 months ago

@FranECross Forgot to add here that this was pulled in as stretch for sprint 9.

randimays commented 2 months ago

The code here was successfully deployed to production. As far as I know, there are no existing production promo banners. In prod CMS:

Screenshot 2024-08-06 at 1 41 27 PM

I tested this in Tugboat with some dummy data, so as long as the CI is passing, that is the most testing in production we can do unless there is a promo banner added. Closing as complete!