department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

[Analytics] [Dupe GA Events] Remove duplicate GA event events-impossible-date-range on FE Events search #18796

Closed FranECross closed 2 months ago

FranECross commented 2 months ago

Description

The duplicate event(s) on FE Events search identified and listed on line 144 in Randi's spreadsheet needs to be removed.

Sitewide FE: Events search

Element: Filtering by Custom date range and clicking "Apply filter" (Impossible date range is entered)

~#### Element: Filtering by Custom date range and clicking "Apply filter" (Valid date entered)~ ~- Event name: events-apply-filter-clicked~ ~- Other event data: ~ ~- "filter-by: {filter}~ ~- filters-list: {list}"~ ~- Example URL: https://www.va.gov/outreach-and-events/events/~

Element: Filtering by Custom date range and clicking "Apply filter" (Apply filter fails because some inputs are missing)

User story

AS A PO/PM of sitewide products I WANT all duplicate events removed from our product's code SO THAT we aren't charged by Google Analytics twice for the 'same' event

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

randimays commented 2 months ago

Updated the description to strike out events-apply-filter-clicked; it was removed between the time the spreadsheet was created and me picking up this ticket.

@FranECross I learned yesterday that form components (e.g. dropdowns, text inputs, etc.) are opt in for analytics (to avoid PHI/PII being captured). Two questions in bold below:

When I...

...I get two events: one is for clicking the "Apply filter" button and the other is for the invalid date range. Should we keep both events?

Screenshot of events Screenshot 2024-08-07 at 1 40 53 PM

Similar situation when you filter by custom date range and don't fill out the fields, then click "Apply filter." You get a click event for the "Apply filter" button and the event for an empty filter. Should we keep both events?

Screenshot of events Screenshot 2024-08-07 at 1 44 39 PM
FranECross commented 2 months ago

@randimays Thanks for the research and info! I don't believe we need the event for the invalid date range.

randimays commented 2 months ago

Verified successfully in production. Closing as complete!