Days of the week on hours for Facility service locations sometimes say "and" on Node:View

[laflannery]

Description

While reviewing VBA content for approval and go live, Michelle discovered an bug within the Hours section on the service location paragraph.

Sometimes, though we haven't yet been able to determine a pattern, the day of the week doesn't show on the view screen, instead the word "and" displays.

Examples

• Togus Service location on Prod
  First location looks good

Second location has "and" on Thursday


Third - Ninth locations looks good (didn't screenshot them all)


Tenth location has "and" for Thursday


• Some Tugboat examples that are showing the issue:
  • Every Thursday except the first location: https://main-2pegzvqcy77ynmcultaityqtlrpfbfoo.demo.cms.va.gov/node/70819
  • Every Monday except the first location: https://main-2pegzvqcy77ynmcultaityqtlrpfbfoo.demo.cms.va.gov/node/70821
  • Every Thursday except the first location: https://main-2pegzvqcy77ynmcultaityqtlrpfbfoo.demo.cms.va.gov/node/70820
  • Second location Monday (there are only 2 locations here): https://main-2pegzvqcy77ynmcultaityqtlrpfbfoo.demo.cms.va.gov/node/70822

Additional Context

Original slack thread where this was reported

From Christian: The part of the module that generates this: office_hours/src/Plugin/Field/FieldType/OfficeHoursItem.php

public static function formatLabel(string $pattern, array $value, $day_delta = 0) {
    $label = NULL;

    $day = $value['day'];
    switch (TRUE) {
      case ($day_delta):
        // Return fast for a following slot.
        $label = t('and');
        break;

Acceptance Criteria

• [ ] Testable_Outcome_X
• [ ] Testable_Outcome_Y
• [ ] Testable_Outcome_Z
• [ ] Requires design review
• [ ] Requires accessibility review

[davidmpickett]

This bug appears to be limited to Node:View. It doesn't appear on Node:Edit and doesn't get passed through to the Front End