department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Some PIV users experiencing access issues on specific pages #18859

Open timcosgrove opened 3 months ago

timcosgrove commented 3 months ago

Describe the defect

Some PIV users are reporting that specific pages show them an access denied page. These are pages that they previously had access to.

To Reproduce

This unfortunately is unreproduceable by other people. The problem is specific to certain users and certain pages. See also notes under Additional Context.

Randi Hecht:

  1. Goes to https://prod.cms.va.gov - gets 'Access Denied'

Sara Torres:

  1. Goes to https://prod.cms.va.gov/resources/about-electronic-health-information-sharing-at-va, hits 'Edit' (she does have access to edit the page)
  2. Gets 'Access Denied'

Beth Potts:

  1. Help Desk has reached out to determine the steps.
  2. What they found is that Beth Potts is a content admin, so she should have access to everything.

AC / Expected behavior

Users should be able to access pages they have role-based access to.

Screenshots

Image

Additional context

The general pattern is:

  1. User is logged in via PIV.
  2. User goes to a page that they have role-based access to.
  3. User is redirected to https://prod.cms.va.gov/saml_login
  4. https://prod.cms.va.gov/saml_login is actually not meant to be accessible by an authenticated user, and they DO remain logged in, so the user gets 'Access Denied'.
  5. The user continues to be logged in and can access other pages as normal without logging back in.

Additional information that has come back from working with users experiencing the problem:

Acceptance Criteria

timcosgrove commented 3 months ago

One error type I see in the logs indicates a user is being returned from logon.iam.va.gov without an appropriate adUPN attribute set

Drupal\simplesamlphp_auth\Exception\SimplesamlphpAttributeException: Error in simplesamlphp_auth.module: no valid "adUPN" attribute set. in Drupal\simplesamlphp_auth\Service\SimplesamlphpAuthManager->getAttribute() (line 284 of /var/www/cms/docroot/modules/contrib/simplesamlphp_auth/src/Service/SimplesamlphpAuthManager.php). [dd.trace_id=9223372036854775807 dd.span_id=4039230175985604495]

https://prod.cms.va.gov/admin/reports/dblog/event/4608084 (may be removed; not sure how long these are retained).

This has happened multiple times; it is not unique to the above. However, this doesn't seem clearly associated with the reported problem.

gracekretschmer-metrostar commented 3 months ago

All users known to have this issue have had the issue resolved by using a different browser, so we are going to move this to the parking lot until we get more information about the problem and/or hear from more users experiencing the issue.

Full discussion here: https://dsva.slack.com/archives/CT4GZBM8F/p1723747595417829

gracekretschmer-metrostar commented 2 months ago

Erika had an idea that it's users who have the translations set up and, specifically, if that module is the underlying issue.

Beth Potts has also reported experiencing the same issue.

ian-sears commented 2 months ago

CMS HD report from an Editor: Name: Linda.Wondra@va.gov Browser: ??? will ask and update here URL being accessed: ??? will ask and update here Also asking how recently she cleared her broswer cahce and if trying the "other" browser resolved it. Also asking how recently she was able to use this URL normally.

ian-sears commented 2 months ago

Name: megan.zehnder@va.gov Meghan writes: As of today, I’m still experiencing the issue.

Oddly, yesterday I encountered the issue much less frequently. I was able to go back into Edit mode in a Drupal page multiple times without clearing my cache and re-entering my PIV each time. But when I worked on a different post today, I hit the “Access denied” screen every time I tried to go back into Edit mode.

Here are some observations that may or may not be helpful!

TroyCMSSupport commented 2 months ago

@timcosgrove - @ian-sears @gracekretschmer-metrostar A new piece of information regarding Access Denied -- A common thread: Editors are clicking on 'Home' in the breadcrumb trail at the top of the page. This leads them to the Home page - forcing them to log in again - THIS is when the Access Denied message appears... Editors report that the functionality of this changed 3 or so months ago. The Home link should take them to the same page as clicking on their user name at the top of the page... image

Additionally from @ian-sears - As an Editor, when I am editing, within the last two months when I click on the breadcrumb "Home". It does not take me to the home page for "me"... it instead asks me to log in again. Workarounds that the Editors have discovered... "Click the VA logo". (or) click your own email address in the menu bar and then "View Profile". This takes them back to what they consider to be their own "home" page (restricted to the sections they have access to edit in WorkBench...)

ian-sears commented 2 months ago

Although unable to shoot a video of this, the Editor Clifford.Coy@va.gov provides this (if verbose) clear text sequence of how he experiences this:

Sure, happy to help. I have the knowledge to do what you are asking, in terms of a video, but not the set up for it. I would have to do some odd video call on teams, and then record that, then compress it…..that is a little more work than I want to do. I can tell you that I have went a head and played around a bit more and I get this response after doing pretty much anything in the page. So, if I clear the browser cache…no issues, I can log in like normal. I use this link: https://prod.cms.va.gov/section/vha/vet-centers/boston-vet-center I select the “edit” button for the Main vet center page section. That takes me here: https://prod.cms.va.gov/node/3597/edit?destination=/section/vha/vet-centers/boston-vet-center which is a logon for my PIV. I click that and I am in the edit cms for my page.

After that, I can do what I want, but as soon as I navigate away or click anywhere else and then try to get back into the edit page, it takes me to the piv log in page and I get nothing but access denied, until I clear the cache again. I tested this by just closing the window, “x” ing out as the kids call it. Then using the above listed link https://prod.cms.va.gov/section/vha/vet-centers/boston-vet-center get back in. From my cms edit page: https://prod.cms.va.gov/node/3597/edit?destination=/section/vha/vet-centers/boston-vet-center&check_logged_in=1 I have navigated to the knowledge base: https://prod.cms.va.gov/help, my profile: https://prod.cms.va.gov/user/3136, after logging out. If I navigate anywhere or click anywhere and then try to get back in without first clearing the cache, it blocks me. I only tested this on edge, not any other browsers.

-Cliff

From VAHELP-7971 VA CMS Help Desk

ian-sears commented 1 month ago

UPDATE: I just followed up with an Editor that had been experiencing this issue (reported) a little over a month ago. ANSWER: Yes. Although it continues to say Access Denied and force a re-login, it is ONLY when she clicks on the breadscrumb for "Home".

I am asking her if it occurs in any other way, and will report here if that is thee case..

gracekretschmer-metrostar commented 3 weeks ago

Another report of this issue here: https://dsva.slack.com/archives/CDHBKAL9W/p1730129417455099

TroyCMSSupport commented 1 week ago

@timcosgrove @ian-sears @gracekretschmer-metrostar - Megan Zehnder has reported in Slack that she is still experiencing this issue.

I tried several ways to reproduce, but still have been unable to.

For my next trick, I will set my account to be just like hers and try again to reproduce... but she is a content admin, assigned to ALL sections -- not really different from

gracekretschmer-metrostar commented 4 days ago

Pull in for sprint 24. Edmund will pull in more logging around login and search the logs for errors.

TroyCMSSupport commented 4 days ago

@gracekretschmer-metrostar @timcosgrove @ian-sears Looks like we've had 11 specific users report the 'Access Denied' screen over the course of 14 Jira tickets (some users created multiple tickets).

The 'typical' workaround has included: clearing browser cache, using alternate browser (these have worked with some success, but often not a permanent solution).

Another finding from an Office Hours meeting is that using the 'Content' button to find content may trigger the 'Access Denied' message - although, I replicated Megan Z's settings on a test account last week, accessed the same content she was denied access to, and I could not replicate the issue. She is a Content Admin, but most reports are from VAMC Editors.

In that same office hours meeting, it was suggested by an editor that navigating to the Content page by clicking on the Editor's email address at the top of the page seems to bypass the 'Access Denied' scenario -- Again, I have not been able to prove/disprove, or otherwise replicate that scenario.

I am wondering if this may have to do with browser VERSION. - No evidence of that either.

TroyCMSSupport commented 4 days ago

@ian-sears @gracekretschmer-metrostar @timcosgrove I have documented as - many as I can identify - of the related Jira tickets:

https://hitssllc-my.sharepoint.com/:x:/p/troy_griffin/ERNitSMWjqZIslT786477m8BjYW1TvsG3JgvXisQ-ht3yA?e=3tuPyN&nav=MTVfezI4Njc0QURDLUNENUUtNDhDNC1BRUYyLUI2MjRCNjdBRDQyOH0

edmund-dunn commented 1 day ago

I found this for Linda.Wondra@va.gov

Oct 31 23:07:37 ip-10-247-33-27 drupal: https://prod.cms.va.gov|1730416057|access denied|10.247.32.79|https://prod.cms.va.gov/saml_login|https://prod.cms.va.gov/user/2147|4|2147||Path: /saml_login. Drupal\Core\Http\Exception\CacheableAccessDeniedHttpException: This route can only be accessed by anonymous users. in Drupal\Core\Routing\AccessAwareRouter->checkAccess() (line 115 of /var/www/cms/docroot/core/lib/Drupal/Core/Routing/AccessAwareRouter.php).