department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 68 forks source link

Header Contact Us link hard coded to point to prod; should be relative to env #18984

Open jilladams opened 2 months ago

jilladams commented 2 months ago

Description

The "Contact us" link in the header is an absolute URL that always points to prod. Clicking this in the staging environment will route user to the actual va.gov/contact-us.

This is a problem for user research flows or testing that may be conducted in Staging, and redirect logged in users to the production environment, where they aren't.

Engineering notes / background

Link is set here for modernized site / header: https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/platform/site-wide/user-nav/components/SearchHelpSignIn.jsx#L122

href="https://www.va.gov/contact-us/"

Per Randi:

The modernized header can be changed in any way as though the Teamsites header does not exist (and we can make the URL relative). Teamsites should continue to point to prod.

Quality / testing notes

Make sure we are only modifying the desktop header.

Mobile header and Injected header have separate markup, and shouldn't be modified.

Acceptance criteria

Agile6MSkinner commented 2 months ago

Hey team! Please add your planning poker estimate with Zenhub @chriskim2311 @eselkin

@jv-agile6 @SnowboardTechie - You may not feel ready to point, but FYI. Comment if needed.