department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

Confusing error message when disabling the Stories panel on a CLP #19161

Open davidmpickett opened 1 week ago

davidmpickett commented 1 week ago

Describe the defect

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. Go to staging.cms.va.gov (or a Tugboat)
  2. Create a new Campaign Landing Page
  3. Fill out the required fields in the sections Hero banner, Why this matters, What you can do, Stories, VA Benefits
  4. Save the node
  5. Edit the node and go to the Stories section and uncheck the "Enable this page segment" box without changing the content underneath
  6. Attempt to save the node and get this error message. Notice that clicking on the link does nothing Screenshot 2024-09-09 at 4 59 40 PM
  7. Scroll down to the Stories segment and notice that there is no visual indicator that it is the fieldset that contains the error Screenshot 2024-09-09 at 4 59 48 PM
  8. Check the "Enable this page segment" box. Notice that there is a confusing error message that says image is required. Screenshot 2024-09-09 at 4 59 58 PM
  9. Click the Remove button next to Link teaser with image to remove the image
  10. Uncheck the "Enable this page segment" box.
  11. Save the node

Possible culprits / solution directions

AC / Expected behavior

FranECross commented 3 days ago

@FranECross The other ticket where clearing fields when segment is unchecked might fix this. Table this until that one is worked on and then test this one.