department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Bug: Improper Wrapping of Service location hours #19239

Closed laflannery closed 3 weeks ago

laflannery commented 1 month ago

Description

A FE defect was found today where the "Wed." service hours are not displaying properly: image

There's a chance the issue might have to do with the font size - if you change the font back to the smaller 16px font (rather than the newer 16.96px), this displays correctly. However, I can't figure out why this issue is showing up now and not months ago, when the typography update actually took place.

However, regardless of how it happened, The font size is correct for the new standard font across VA so we don't want to change it. We should make whatever updates are necessary to properly display these service hours at this font size. This is happening on VAMC Service locations, VBA Service locations and VAMC Non-clinical services

Acceptance Criteria

jilladams commented 1 month ago

@Agile6MSkinner flagging from sprint planning chat: Michelle would like us to look at this defect when we get a chance, so we should prob prioritize for refinement / ready, in case folks end up with capacity to pull something in.

Agile6MSkinner commented 1 month ago

I noted it as a bug and moved it to next refinement. Asked about priority in Slack. Likely candidate for brining into sprint 13 as stretch if not prioritizing.

Edit: @mmiddaugh mentioned it as a good swap.

Agile6MSkinner commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @randimays @eselkin @dsasser @chriskim2311 @SnowboardTechie @jv-agile6

randimays commented 1 month ago

Verified the fix on production. There was a conflict with styles coming from vets-website (a shared CSS class between the repos). I changed the content-build element's CSS class and adjusted the styles accordingly. Also validated that the text scales appropriately with browser font size, and validated all the example pages on desktop and mobile. 👍🏻

Closing as complete.

laflannery commented 1 month ago

I was reviewing this and noticed that the times are no longer left aligned like they used to be, I discussed with @thejordanwood and from a design/UX perspective she agreed that the readability would be better to have these left aligned. For reference, the times used to look like this:

Image

But now there is not a straight left alignment for the hours:

Image

@randimays and @Agile6MSkinner is this something this ticket can be reopened for or a new ticket should be created instead?

randimays commented 1 month ago

I think it's ok to re-open this ticket (to save us some admin time / effort). But I'm not sure I will get back to this, this sprint.

davidmpickett commented 3 weeks ago

Verified on prod