search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

New VAMC System: VA Manila, and launch plan #19271

Open jilladams opened 2 months ago

jilladams commented 2 months ago

Acceptance criteria

Information needed from Product / VHA DM

Create a new menu through config PR [Drupal Engineer]

Create initial VAMC System Drupal entities [CMS helpdesk or Sitewide team]

Create one copy of each of these hardened VAMC content types [CMS helpdesk or Sitewide team]

URLS BELOW HAVE ALL BEEN UPDATED TO USE /manila-va-clinic/ as the root

Clone (from where?) these semi-hardened VAMC detail pages [CMS helpdesk or Sitewide team]

Find any existing VAMC facilities that belong to this system [CMS helpdesk or Sitewide team]

Menu configuration and clean up [CMS helpdesk or Sitewide team]

User set up [CMS helpdesk]

VAMC editor tasks

Launch plan

VHA DM

Engineering team

Do we need?

LAUNCH

jilladams commented 2 months ago

Manila section & content in it: https://prod.cms.va.gov/admin/content?title=Manila&type=All&moderation_state=All&owner=1187

jilladams commented 2 months ago

Questions that may affect Manila:

  1. Menus: there are content types shown where the menu should be added, but if I'm a Content creator / publisher for the Manila section, I don't see menu options on those content types at all. Do we need to make the menu / content type relationship if the relevant editors can expose things to the menu anyway? Or is that bc Admin should be doing the menu pieces? This may need a runbook edit as well. ANSWERED BELOW

  2. Other Programs pages use the path /system/programs. This one was set to auto, /programs. I updated it to https://prod.cms.va.gov/manila-va-system/programs, but we need to change if that's not right. ANSWERED BELOW

  3. I noted the links that were in use for many of these pages. Should the runbook include updating them to use the correct system slug? Or we expect the editor to do that? NEED VHA DM / MICHELLE TO DECIDE: Editor or Helpdesk

  4. Can @davidmpickett help confirm the IA for the menu, based on content strategy? https://prod.cms.va.gov/admin/structure/menu/manage/manila-va-clinic - it seems to have been strategically built the way it is , but I have questions about why some things are where they are, so not 100% sure on status of that part of the checklist ANSWERED BELOW

Runbook edits / danglers to be addressed in #15264

  1. "Set some menu links to disabled " - why? which ones? Can we get more granular for the runbook?
    This is all in the VAMC sitemap in sharepoint and we could map it into the runbook instead.

  2. " Enable the menu in Menu Breadcrumbs module - 9/19: not done in prod yet for Manila. should it be?

  3. "Update CONTENT BUILD FILE with the menu" -- ??

  4. "Create users if need / assign users to the appropriate section [link to KB article]" - need to find the KB if it exists, or write a ticket to make one if it doesn't

  5. UPdate "Do all the things listed here" to "Do all the things listed in the VA Medical Centers (VAMCs) Knowledge base article

  6. "Do we have an editor facing checklist for content entry / tasks that gate publishing like we do for VBA?" - answer this and update in the runbook

  7. For VBA we broke out the new runbook from the launch runbook. I think these steps belong in a Launch runbook, otherwise you have the "new system" runbook hanging out for a zillion years while Editor creates content. But is that a bad idea? We should check with Michelle & Helpdesk.

  8. Consult VAMC sitemap in sharepoint for menu settings -

  9. We need to figure out how to help Helpdesk or Editors know where to copy from to generate all the random un-hardened pages (e.g. Programs, etc.). There used to be template pages from 2021, we think, but they've aged and content isn't up to date. Can we say: copy from the most recently edited version from another VAMC / fix links? What's reasonable?

  10. Sidenav: we say to use the Services/Locations and Events fake headers in the menu, BUT: a11y has said we want to move away from that paradigm. So: the runbook is advising an old pattern.

davidmpickett commented 2 months ago
  1. Menus: there are content types shown where the menu should be added, but if I'm a Content creator / publisher for the Manila section, I don't see menu options on those content types at all. Do we need to make the menu / content type relationship if the relevant editors can expose things to the menu anyway? Or is that bc Admin should be doing the menu pieces? This may need a runbook edit as well.

I was also confused why we enabled have Menu settings on these content types. However, all other VAMC system menus are enabled. In lieu of strong evidence that it is a problem, I opted for consistency with previous systems. If it ain't broke, don't fix it mentality.

davidmpickett commented 2 months ago
  1. Other Programs pages use the path /system/programs. This one was set to auto, /programs. I updated it to https://prod.cms.va.gov/manila-va-system/programs, but we need to change if that's not right.

Good catch! I wasn't sure if the Programs page should automatically get the correct alias, but wasn't because of other things not being fully configured. But looking at some other Program pages, they do seem to be manually over-riden, so the runbook should relfect that step.

davidmpickett commented 2 months ago
  • [ ] VAMC detail page - as Manila editor in Tugboat, Manila VA Clinic is not present in the list of menu options

I think that will be resolved by this ticket: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19199

davidmpickett commented 2 months ago
  1. Can @davidmpickett help confirm the IA for the menu, based on content strategy? https://prod.cms.va.gov/admin/structure/menu/manage/manila-va-clinic - it seems to have been strategically built the way it is , but I have questions about why some things are where they are, so not 100% sure on status of that part of the checklist

The source of truth for this is the Manila sitemap in sharepoint. Happy to explain why this differs from the general Sitemap of a VAMC system in sharepoint.

davidmpickett commented 2 months ago
  1. I noted the links that were in use for many of these pages. Should the runbook include updating them to use the correct system slug? Or we expect the editor to do that?

I think by this you mean things like how the Women Veteran Care page has links to the Mental health care and Patient Advocate pages? And those links are still pointing to the Pacific Islands system I copied the pages from?

Even if we expect the editor to do it, might be good to add to editor steps in the runbook. At very least, a good thing for the change management

davidmpickett commented 2 months ago
  1. " Enable the menu in Menu Breadcrumbs module - 9/19: not done in prod yet for Manila. should it be?

Yup, it's listed in the overflowticket https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19270

davidmpickett commented 2 months ago
  1. "Update CONTENT BUILD FILE with the menu" -- ??

https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19273

jilladams commented 2 months ago

Under normal circumstances, it would be: System = /PLACE-health-care Facility = /PLACE-health-care/FACILITY-NAME

Manila is weird because the Facility IS the root of the system. So: System = will not publish, does not get a FE page. How? There's a FE ticket to figure this out. #19272 Facility = /manila-va-clinic

SO: all paths for all the Manila pages should include /manila-va-clinic/ as the root.

jilladams commented 2 months ago

Next steps:

  1. Jill to fixup paths and check for content references to Pacific Healthcare in node bodies, since that's what we copied.
  2. Need to port the bigger picture Runbook changes back to the runbook ticket. - @davidmpickett
  3. Need to share the Manila content link to Justin, Michelle to pass on to the Editor. cc Helpdesk. BE SURE TO INCLUDE:
    1. Do not publish until content is complete. Please reach out to (?)

Link of Manila VA content that the Editor will need. https://prod.cms.va.gov/admin/content?title=&type=All&moderation_state=draft&owner=1187

Emailed Justin to clarify how we get things to the Editor. (Via VHA DM or Helpdesk.)

davidmpickett commented 2 months ago

@Agile6MSkinner @jilladams FYI - I moved all notes here about updates to make/consider to the runbook over to the runbook ticket #15264 Gonna unassign myself from this ticket now

jilladams commented 2 months ago

Content updates are done, to fix path and remove Pacific Island info, where it was sensible to do so.

Pages where I cannot modify path as admin

Billing/Insu - https://prod.cms.va.gov/node/72610/edit Med records - https://prod.cms.va.gov/node/72697/edit Operating status - https://prod.cms.va.gov/node/72699/edit Register for care - https://prod.cms.va.gov/node/72706/edit Top task - https://prod.cms.va.gov/node/72703/edit Police - https://prod.cms.va.gov/node/72704/edit

Before those get published, if they do, we need to figure out whether we can modify the path. I suspect the paths are supposed to be autobuilt for these based on section, using system node path, but that's not gonna work for Manila. Stub to track: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19280 (FYI @Agile6MSkinner )

jilladams commented 1 month ago

We decided https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19227 is not launch blocking.

jilladams commented 1 month ago

Today I yolo'ed and Published > Archived the production System node, since that had not yet been done and is a requirement for everything else to work.

jilladams commented 1 month ago

Doing Tugboat content review after launch blocking changes are done, we think: https://dsva.slack.com/archives/C0FQSS30V/p1729611500413259

Takeaways for follow up:

Performance page: appears as a not clickable link in the left sidenav, with current IA / menu setup:

https://prod.cms.va.gov/manila-va-clinic/performance

Image

Image

Per Eli: To fix the issue I noted, a menu item needs to be added for Performance to nest under. This is something about how vets-website builds the menus. There's probably a way to change it, but it's not super easy

Register for care 404s

Make an appointment is set up the same way, but works:

Image

Story nodes are using the System path

https://web-xwykohumwbnvcp90arpvpzfkcilh2ngo.demo.cms.va.gov/manila-va-clinic/stories/ https://web-xwykohumwbnvcp90arpvpzfkcilh2ngo.demo.cms.va.gov/manila-va-system/stories/test-story-2/ https://web-xwykohumwbnvcp90arpvpzfkcilh2ngo.demo.cms.va.gov/manila-va-system/stories/test-story/

Not sure if that will have to be fixed per node that's created, or if we can systematically fix to prevent problems in future?

davidmpickett commented 1 month ago

All of these might need a fix similar to https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19280

davidmpickett commented 1 month ago

Register for care 404s

@jilladams This may be specific to your environment. I'm not sure if the work @omahane did in #19280 works on lower environments. On Prod the Register for Care page in Drupal has the correct path https://prod.cms.va.gov/manila-va-clinic/register-for-care

Your tugboat still has it with the system URL path. /manila-va-system/register-for-care

jilladams commented 1 month ago

Hm, good catch. I thought I built my Tugboat after Prod content changes had all shipped, so it should have had all the same settings / paths as prod, with the only difference being what was published / not published. But clearly not so. I'm gonna rebuild it in order to make that true, and rebuild the FE, to confirm.

davidmpickett commented 1 month ago

@jilladams That was my initial thought too, that if you rebuilt Tugboat it would start working, but actually I think that the way @omahane made these updates means they will not port to lower environments. https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19280#issuecomment-2430012608

davidmpickett commented 1 month ago

@jilladams MEA CULPA. It was just a Tugboat issue. I forgot about the lag between deploys and base previews rebuilding etc. etc. @omahane and I just looked at your Tugboat and it's fine now

jilladams commented 1 month ago

TUGBOAT TESTING ITEMS

Testing against Sitemap in Sharepoint, testing notes are documented there as well.

  1. Manila VA Clinic page: Title metatag is Manila VA Clinic | Manila VA Clinic | Veterans Affairs. Need to assess if launch blocking. -- @mmiddaugh @Agile6MSkinner @davidmpickett
  2. Operating Status: has | Manila VA Clinic tacked to the end of the otherwise correct breadcrumbs. Not launch blocking /matches other VAMCs in prod, e.g. Augusta VAMC Operating status. Related slack thread. Ticketed: https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19608
  3. Performance & Leadership: don't appear under About Us in menu / path. Rebuilding tugboat to verify if still broken after path updates. If so: is launch blocking to fix but I think they'll be ok after rebuild.

Changes I made to the menu

Reordered menu items to match the sitemap order, including nesting Leadership and Performance under About Us. Tugboat menu: https://cms-xwykohumwbnvcp90arpvpzfkcilh2ngo.demo.cms.va.gov/admin/structure/menu/manage/manila-va-clinic Prod menu: https://prod.cms.va.gov/admin/structure/menu/manage/manila-va-clinic

Changes I made to the sitemap

jilladams commented 1 month ago

1 page title is not launch blocking per Michelle.

3 is now working: pages appear correctly in the About Us section with correct crumbs, Title, and path.

https://web-xwykohumwbnvcp90arpvpzfkcilh2ngo.demo.cms.va.gov/manila-va-clinic/about-us/performance/ https://web-xwykohumwbnvcp90arpvpzfkcilh2ngo.demo.cms.va.gov/manila-va-clinic/about-us/leadership/

Letting Justin know that editor is clear to make / publish everything with the exception of Stories / Staff / Events / News Releases.