search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 69 forks source link

Manila: path updates required due to snowflake setup #19280

Closed jilladams closed 3 days ago

jilladams commented 1 month ago

Description

There are some Manila pages using default paths that are incorrect due to the special nature of the Manila setup.

System path

Under normal circumstances, a VAMC System path would be: System = /PLACE-health-care Facility = /PLACE-health-care/FACILITY-NAME

Manila is weird because the Facility IS the root of the system. So: System = will not publish, does not get a FE page. How? There's a FE ticket to figure this out. https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19272 Facility = /manila-va-clinic

Affected node paths

These hardened pages are using the default system path, which is incorrect for Manila. Path cannot be overridden on these nodes (the Path options do not appear on the right sidebar of the node pages):

Needed: VAMC System Billing and Insurance - https://prod.cms.va.gov/manila-va-clinic/billing-and-insurance VAMC System Medical Records Office - https://prod.cms.va.gov/manila-va-clinic-system-node/medical-records-office VAMC System Operating Status - https://prod.cms.va.gov/manila-va-clinic-system-node/operating-status VAMC System Register for Care - https://prod.cms.va.gov/manila-va-clinic-system-node/register-for-care

Not needed: VAMC System Policies Page - https://prod.cms.va.gov/manila-va-clinic-system-node/policies VAMC System VA Police page - https://prod.cms.va.gov/manila-va-clinic-system-node/va-police

Editor info

Manila editor has verified that 4 of these pages will be required. This ticket is launch blocking.

Prerequisites

ACs

davidmpickett commented 3 weeks ago

Likely controlled by: https://prod.cms.va.gov/admin/config/search/path/patterns

For Lovell there is a bit of Code in the backend module that disables pathauto for Lovell pages. https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/docroot/mod[…]tom/va_gov_lovell/src/EventSubscriber/LovellEventSubscriber.php Might make sense to have something similar for Manila if we are going to do them all manually

Agile6MSkinner commented 3 weeks ago

Need to reach out to the editor to determine if these are needed and thus launch blocking. Helpdesk to reach out.

jilladams commented 3 weeks ago

Asked Helpdesk for an assist here: https://dsva.slack.com/archives/C02730UEZPS/p1727729745619329

jilladams commented 3 weeks ago

Helpdesk outreach to the editor: https://va-gov.atlassian.net/jira/servicedesk/projects/VAHELP/queues/custom/11/VAHELP-8073

jilladams commented 2 weeks ago

Editor verified they do need 4 of the 6 pages. This ticket is launch blocking, I updated ticket body and launch plan in #19271 accordingly.

jilladams commented 2 weeks ago

@jilladams to clarify with the Editor re: whether the centralized content will / won't apply, and wehther a VAMC detail page may be a better fit for the "Need" content of these top task pages.

Pulling into sprint, but: let's wait to start it til I have that info.

omahane commented 2 weeks ago

@davidmpickett If manila-va-clinic is the root path for all content, that means we will end up with a facility (Manila VA Clinic) that is at https://prod.cms.va.gov/manila-va-clinic/manila-va-clinic and thus is at https://va.gov/manila-va-clinic/manila-va-clinic.

That may be fine, but I wanted to let you know.

I also notice that none of the health services are of the health services content types but are instead Detail pages. Why is that?

davidmpickett commented 2 weeks ago

@davidmpickett If manila-va-clinic is the root path for all content, that means we will end up with a facility (Manila VA Clinic) that is at https://prod.cms.va.gov/manila-va-clinic/manila-va-clinic and thus is at https://va.gov/manila-va-clinic/manila-va-clinic.

That may be fine, but I wanted to let you know.

I set the URL alias of the clinic to be https://prod.cms.va.gov/manila-va-clinic Are you saying there's something that will override that?

I also notice that none of the health services are of the health services content types but are instead Detail pages. Why is that?

Those aren't health services, they are health service Care Coordinator pages. These are on all VAMCs but are not super obvious because they aren't in the side nav. Example: https://www.va.gov/chicago-health-care/health-services/mental-health-care/

They are typically linked to from the System health service in the last line of the description https://www.va.gov/chicago-health-care/health-services/#item-mental-health-care

omahane commented 5 days ago

@davidmpickett I have updated the paths (at the https://prod.cms.va.gov/admin/config/search/path) for the needed pages.

For the pages we don't need (Policies and Police), should we archive or delete?

omahane commented 5 days ago

I just tried to create a system health service (on Staging) and got this: https://staging.cms.va.gov/manila-va-system/health-services/addiction-and-substance-use-care-at-manila-va-clinic

I think we want this to be https://staging.cms.va.gov/manila-va-clinic/health-services/addiction-and-substance-use-care-at-manila-va-clinic

Then, when I created the facility health service, I got this https://staging.cms.va.gov/manila-va-clinic/addiction-and-substance-use-care

Maybe it's fine, especially as we're not publishing the system page anyway, so there's no need to show these anywhere.

jilladams commented 5 days ago

Dave's out til Tuesday next week: let's archive, as the System may find they need these nodes later.

You are correct that we want th health service path to use manila-va-clinic not manila-va-system. If we don't think it's impactful, yay. I'm not certain of the implications -- we're saying the System health service page won't be visible to anyone bc we don't have a standard system page? (We have to make those in order to enable making a Facility Health Service right?)

omahane commented 4 days ago

Right, the system health services are typically listed on the system page in Drupal, but they don't show on the front-end. So I don't think it really matters what their URL is. The facility health services have the correct path, which is more important.

jilladams commented 3 days ago

I archived the nodes we don't need. The work here is done. The open question around the System health services paths is worth getting product to acknowledge the situation / decide if we need to programmatically ward against it, which we could roll into #19406 if so. CLosing this, and flagging that convo for scrum next week.