Screen-size breakpoint name changes for Facilities

[eselkin]

User Story or Problem Statement

After update of DST screen size breakpoint name changes, recently old names are no longer respected.

Description or Additional Context

Steps for Implementation

Acceptance Criteria

• [x] Change all Facilities pages from large-screen: to desktop-lg:
• [x] Change all Facilities pages from small-desktop-screen: to desktop:
• [x] Change all Facilities pages from small-screen: to mobile-lg:
• [x] Change all Facilities pages from xsmall-screen: to mobile:
• [ ] Requires design review
• [ ] Requires accessibility review

[jilladams]

@eselkin thanks for making this ticket last week. I see 2 merged PRs - can you help note what got covered from the ACs here, vs. what might be left to do, if anything? (And maybe @chriskim2311 too?)

I see the following checks on the Facilities PRs:

• Vet Center pages render as before the update (i.e. images on right side of address block)
• VAMC pages render as before the update (ditto)

And I know there was a PR for CLPs separately under #19348

But not sure if we got through all our templates for things like VBA, Events, press Releases, etc etc etc where images might appear and be affected.

cc @Agile6MSkinner @FranECross

[eselkin]

All screen sizes other than medium were changed to the new USWDS names except with respect to the ones preceding a grid or col class name. Those were kept because they are not changed yet in the DST updates.

[eselkin]

That is. All inside any Facilities product and on the home page.

[eselkin]

There may be some in facility locator that need an update still. Just saw something and will check.

[jilladams]

Noting: we left this ticket open, in order to track follow up after the final DST change to breakpoints. I'm not sure if there was a specific change we were on the lookout for, so:

DST merged PRs that mention breakpoints: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/pulls?q=is%3Apr+breakpoint+is%3Aclosed

DST issues that mention breakpoints (open & closed: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues?q=is%3Aissue%20breakpoints

[eselkin]

The DST PRs about breakpoints have been more often mentioning CSS swap or CSS naming something, rather than overtly saying breakpoints in the titles. There's one open for FL that I was waiting on the RI for.

[eselkin]

The changes they are making are not always DS changes but changes in vets-website or C-B

[jilladams]

Ah ok - so am gonna continue reporting htis as open to track changes. I'll ping DST to see where they are in terms of completion. Thanks!

[jilladams]

https://dsva.slack.com/archives/C04868KS69L/p1729094616622629

• For breakpoint name changes: We have one outstanding utility to swap, which is the margin utility. We have a developer working on this currently and he's close to wrapping up. I expect this to be done end of week or sometime next week.
• For the CSS shared-variable import swap: Work on this just kicked off and it should be completed by the end of this sprint, October 23rd.
• For the core.scss import swap from Formation to css-library: We're in the middle of testing these changes locally. This is a larger effort, and I expect this specific import swap to be completed around the beginning of December, but potentially earlier. We've tested changes on profile, mvh secure messaging, and several hub pages in content-build. Things look good, but I'd like to do a little more testing here